From 0177a578e87aaa6d1bebeaeeea2f23fa9f95e28b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=93scar=20Gonz=C3=A1lez=20Fern=C3=A1ndez?= Date: Fri, 28 Aug 2009 13:07:07 +0200 Subject: [PATCH] ItEr23S03ContornaItEr22S03: Doing defensive copy of array parameters --- .../common/exceptions/ValidationException.java | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/navalplanner-business/src/main/java/org/navalplanner/business/common/exceptions/ValidationException.java b/navalplanner-business/src/main/java/org/navalplanner/business/common/exceptions/ValidationException.java index 3ea2fa958..b6e84779a 100644 --- a/navalplanner-business/src/main/java/org/navalplanner/business/common/exceptions/ValidationException.java +++ b/navalplanner-business/src/main/java/org/navalplanner/business/common/exceptions/ValidationException.java @@ -17,27 +17,28 @@ public class ValidationException extends Exception { public ValidationException(InvalidValue[] invalidValues) { super(); + storeInvalidValues(invalidValues); + } + + private void storeInvalidValues(InvalidValue[] invalidValues) { Validate.noNullElements(invalidValues); - this.invalidValues = invalidValues; + this.invalidValues = invalidValues.clone(); } public ValidationException(InvalidValue[] invalidValues, String message, Throwable cause) { super(message, cause); - Validate.noNullElements(invalidValues); - this.invalidValues = invalidValues; + storeInvalidValues(invalidValues); } public ValidationException(InvalidValue[] invalidValues, String message) { super(message); - Validate.noNullElements(invalidValues); - this.invalidValues = invalidValues; + storeInvalidValues(invalidValues); } public ValidationException(InvalidValue[] invalidValues, Throwable cause) { super(cause); - Validate.noNullElements(invalidValues); - this.invalidValues = invalidValues; + storeInvalidValues(invalidValues); } public ValidationException(String message) {