From 03febe580f04d5e2902a18c318db0942a3f426af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=93scar=20Gonz=C3=A1lez=20Fern=C3=A1ndez?= Date: Mon, 21 Feb 2011 15:14:36 +0100 Subject: [PATCH] [Bug #871] The problem is due to receiving an empty list of tasks When the critical path received is empty the PlanningDate can't be updated. Instead a warning is logged. FEA: ItEr71S04BugFixing --- .../business/planner/entities/PlanningData.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/navalplanner-business/src/main/java/org/navalplanner/business/planner/entities/PlanningData.java b/navalplanner-business/src/main/java/org/navalplanner/business/planner/entities/PlanningData.java index fd7e14a9b..0ada6def6 100644 --- a/navalplanner-business/src/main/java/org/navalplanner/business/planner/entities/PlanningData.java +++ b/navalplanner-business/src/main/java/org/navalplanner/business/planner/entities/PlanningData.java @@ -24,6 +24,8 @@ package org.navalplanner.business.planner.entities; import java.math.BigDecimal; import java.util.List; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import org.navalplanner.business.common.BaseEntity; /** @@ -37,6 +39,8 @@ import org.navalplanner.business.common.BaseEntity; */ public class PlanningData extends BaseEntity { + private static Log LOG = LogFactory.getLog(PlanningData.class); + public static PlanningData create(TaskGroup rootTask) { return new PlanningData(rootTask); } @@ -64,6 +68,10 @@ public class PlanningData extends BaseEntity { } public void update(List criticalPath) { + if (criticalPath.isEmpty()) { + LOG.warn("it can't be updated because the critical path provided is empty"); + return; + } progressByDuration = calculateByDuration(criticalPath); progressByNumHours = calculateByNumHours(criticalPath); }