From 0c2d08ec133e1a7f80e4b178c11aca8a462c779c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=93scar=20Gonz=C3=A1lez=20Fern=C3=A1ndez?= Date: Thu, 30 Jun 2011 16:19:45 +0200 Subject: [PATCH] Avoid duplicating visual effect on arrows A background was being applied via css besides the src property. Now divs are used so the duplication is removed. FEA: ItEr75S08MigrationZK5 --- .../web/js/ganttz/DependencyComponent.js | 24 ++++++------------- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/ganttzk/src/main/resources/web/js/ganttz/DependencyComponent.js b/ganttzk/src/main/resources/web/js/ganttz/DependencyComponent.js index cd1d7b42a..583366b0e 100644 --- a/ganttzk/src/main/resources/web/js/ganttz/DependencyComponent.js +++ b/ganttzk/src/main/resources/web/js/ganttz/DependencyComponent.js @@ -118,7 +118,6 @@ ganttz.DependencyComponentBase = zk.$extends(zul.Widget,{ var deparrow = this._findImageElement('arrow'); - deparrow.attr('src', this.$class.getImagesDir() + "arrow3.png"); deparrow.css({top : yend - 5, left : xend - 8}); }, _drawArrowEndStart : function(coordOrig, coordDest){ @@ -155,23 +154,18 @@ ganttz.DependencyComponentBase = zk.$extends(zul.Widget,{ depend.css(dependcss); var deparrow = this._findImageElement('arrow'); - var deparrowsrc, deparrowcss; + var deparrowcss; if ( width == 0 ) { deparrowcss = {top : (yend - 10) , left : (xend - 5)}; - deparrowsrc = this.$class.getImagesDir() + "arrow2.png"; if ( yorig > yend ) { deparrowcss = {top : yend}; - deparrowsrc = this.$class.getImagesDir() + "arrow4.png"; } } else { deparrowcss = {top : (yend -5), left : (xend - 10)}; - deparrowsrc = this.$class.getImagesDir() + "arrow.png"; if (width < 0) { deparrowcss = {top : (yend - 5), left : xend} - deparrowsrc = this.$class.getImagesDir() + "arrow3.png"; } } - deparrow.attr('src', deparrowsrc); deparrow.css(deparrowcss); }, findPos_ : function(element){ @@ -180,22 +174,18 @@ ganttz.DependencyComponentBase = zk.$extends(zul.Widget,{ return {left : (pos2.left - pos1.left), top : (pos2.top - pos1.top)}; }, _findImageElement : function(name) { - var img = jq('.' + name + '', this.$n()); - return img; + return jq('.' + name + '', this.$n()); }, setupArrow_ : function(){ var image_data = [ [ "start", "pixel.gif" ], [ "mid", "pixel.gif" ], [ "end", "pixel.gif" ], [ "arrow", "arrow.png" ] ]; - var img; + var imgDiv; var insertPoint = jq(this.$n()); for ( var i = 0; i < image_data.length; i++) { - img = jq(document.createElement('img')); - img.attr({ - 'class' : image_data[i][0] + " extra_padding", - 'src' : this.$class.getImagesDir() + image_data[i][1] - }); + imgDiv = jq(document.createElement('div')); + imgDiv.attr('class', image_data[i][0] + " extra_padding"); - insertPoint.append(img); + insertPoint.append(imgDiv); } } },{ @@ -342,4 +332,4 @@ ganttz.UnlinkedDependencyComponent = zk.$extends(ganttz.DependencyComponentBase, zk.afterLoad('ganttz',function(){ ganttz.UnlinkedDependencyComponent.molds = ganttz.DependencyComponent.molds; -}) \ No newline at end of file +})