From 1d34ad3549514918aaef129fdf177a353182e55b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=93scar=20Gonz=C3=A1lez=20Fern=C3=A1ndez?=
 <ogonzalez@igalia.com>
Date: Sun, 12 Sep 2010 17:50:54 +0200
Subject: [PATCH] Improve logging for cancellations and errors

FEA: ItEr60S04ValidacionEProbasFuncionaisItEr59S04
---
 .../notification/NotBlockingAutoUpdatedSnapshot.java | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/navalplanner-business/src/main/java/org/navalplanner/business/hibernate/notification/NotBlockingAutoUpdatedSnapshot.java b/navalplanner-business/src/main/java/org/navalplanner/business/hibernate/notification/NotBlockingAutoUpdatedSnapshot.java
index dbbf2b139..ce246c755 100644
--- a/navalplanner-business/src/main/java/org/navalplanner/business/hibernate/notification/NotBlockingAutoUpdatedSnapshot.java
+++ b/navalplanner-business/src/main/java/org/navalplanner/business/hibernate/notification/NotBlockingAutoUpdatedSnapshot.java
@@ -114,6 +114,8 @@ class NotBlockingAutoUpdatedSnapshot<T> implements IAutoUpdatedSnapshot<T> {
                         newValue));
                 return newValue;
             }
+            LOG.info(name + " the ongoing calculation has not been completed. "
+                    + "Returning previous value");
             return previousValue.getValue();
         }
 
@@ -121,18 +123,22 @@ class NotBlockingAutoUpdatedSnapshot<T> implements IAutoUpdatedSnapshot<T> {
             try {
                 return ongoingCalculation.get();
             } catch (Exception e) {
-                LOG.error("error creating new snapshot, keeping old value",
-                        e);
+                LOG.error("error creating new value for " + name
+                        + ", keeping old value", e);
                 return previousValue.getValue();
             }
         }
 
         @Override
         void cancel() {
+            if (ongoingCalculation.isDone() || ongoingCalculation.isCancelled()) {
+                return;
+            }
+            LOG.info(name + " cancelling ongoing future");
             try {
                 ongoingCalculation.cancel(true);
             } catch (Exception e) {
-                LOG.error("error cancelling future", e);
+                LOG.error("error cancelling future for " + name, e);
             }
         }
     }