From 1e1d462412a541feda4ea5c6587ffa75a18e0359 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=93scar=20Gonz=C3=A1lez=20Fern=C3=A1ndez?= Date: Tue, 3 Nov 2009 17:53:27 +0100 Subject: [PATCH] ItEr33S08ValidacionEProbasFuncionaisItEr32S09: Using static valueOf instead of inefficient constructor --- .../navalplanner/business/planner/entities/TaskMilestone.java | 2 +- .../web/orders/ManageOrderElementAdvancesModel.java | 2 +- .../java/org/navalplanner/web/planner/TaskElementAdapter.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/navalplanner-business/src/main/java/org/navalplanner/business/planner/entities/TaskMilestone.java b/navalplanner-business/src/main/java/org/navalplanner/business/planner/entities/TaskMilestone.java index 6faf47b63..f55d2aec7 100644 --- a/navalplanner-business/src/main/java/org/navalplanner/business/planner/entities/TaskMilestone.java +++ b/navalplanner-business/src/main/java/org/navalplanner/business/planner/entities/TaskMilestone.java @@ -109,7 +109,7 @@ public class TaskMilestone extends TaskElement implements IValidable { @Override public Integer defaultWorkHours() { - return new Integer(0); + return Integer.valueOf(0); } @Override diff --git a/navalplanner-webapp/src/main/java/org/navalplanner/web/orders/ManageOrderElementAdvancesModel.java b/navalplanner-webapp/src/main/java/org/navalplanner/web/orders/ManageOrderElementAdvancesModel.java index 320feaec2..bfe98d496 100644 --- a/navalplanner-webapp/src/main/java/org/navalplanner/web/orders/ManageOrderElementAdvancesModel.java +++ b/navalplanner-webapp/src/main/java/org/navalplanner/web/orders/ManageOrderElementAdvancesModel.java @@ -521,7 +521,7 @@ public class ManageOrderElementAdvancesModel implements } LocalDate date = advanceMeasurement.getDate(); if ((value != null) && (date != null)) { - xymodel.addValue(title, new Long(date + xymodel.addValue(title, Long.valueOf(date .toDateTimeAtStartOfDay().getMillis()), value); } } diff --git a/navalplanner-webapp/src/main/java/org/navalplanner/web/planner/TaskElementAdapter.java b/navalplanner-webapp/src/main/java/org/navalplanner/web/planner/TaskElementAdapter.java index 2aa6952ef..cf2122ef4 100644 --- a/navalplanner-webapp/src/main/java/org/navalplanner/web/planner/TaskElementAdapter.java +++ b/navalplanner-webapp/src/main/java/org/navalplanner/web/planner/TaskElementAdapter.java @@ -199,7 +199,7 @@ public class TaskElementAdapter implements ITaskElementAdapter { hours = orderElement.getWorkHours(); } else { advancePercentage = new BigDecimal(0); - hours = new Integer(0); + hours = Integer.valueOf(0); } Integer advanceHours = advancePercentage.multiply(