i18n: Fixing some English strings

FEA: ItEr76S04BugFixing

libreplan-business/src/main/java/org/libreplan/business/advance/entities/AdvanceAssignment.java

@@ -72,7 +72,7 @@ public abstract class AdvanceAssignment extends BaseEntity {
         }
     }
 
-    @NotNull(message = "advance type not specified")
+    @NotNull(message = "progress type not specified")
     public AdvanceType getAdvanceType() {
         return this.advanceType;
     }

libreplan-business/src/main/java/org/libreplan/business/advance/entities/AdvanceMeasurement.java

@@ -108,7 +108,7 @@ public class AdvanceMeasurement extends BaseEntity {
         this.advanceAssignment = advanceAssignment;
     }
 
-    @NotNull(message = "advance assignment not specified")
+    @NotNull(message = "progress assignment not specified")
     public AdvanceAssignment getAdvanceAssignment() {
         return this.advanceAssignment;
     }

libreplan-business/src/main/java/org/libreplan/business/advance/entities/AdvanceType.java

@@ -216,7 +216,7 @@ public class AdvanceType extends BaseEntity implements IHumanIdentifiable{
         this.qualityForm = BooleanUtils.toBoolean(qualityForm);
     }
 
-    @AssertTrue(message = "advance type marked as quality form but is updatable")
+    @AssertTrue(message = "progress type marked as quality form but is updatable")
     public boolean checkConstraintIfIsQualityFormIsNotUpdatable() {
         if (isQualityForm()) {
             if (isUpdatable()) {
@@ -226,7 +226,7 @@ public class AdvanceType extends BaseEntity implements IHumanIdentifiable{
         return true;
     }
 
-    @AssertTrue(message = "default max value of percentage advance type must be 100")
+    @AssertTrue(message = "default maximum value of percentage progress type must be 100")
     public boolean checkConstraintDefaultMaxValueMustBe100ForPercentage() {
         if (percentage) {
             if (defaultMaxValue.compareTo(new BigDecimal(100)) != 0) {
@@ -241,7 +241,7 @@ public class AdvanceType extends BaseEntity implements IHumanIdentifiable{
         return unitName;
     }
 
-    @AssertTrue(message = "Advance Type name already used. It must be unique")
+    @AssertTrue(message = "progress type name is already in use")
     public boolean checkConstraintUniqueName() {
         if (StringUtils.isBlank(unitName)) {
             return true;
@@ -263,7 +263,7 @@ public class AdvanceType extends BaseEntity implements IHumanIdentifiable{
         }
     }
 
-    @AssertTrue(message = "Default Max value must be greater than precision value")
+    @AssertTrue(message = "default maximum value must be greater than precision value")
     public boolean checkDefaultMaxValueGreaterThanPrecision() {
         if (defaultMaxValue.compareTo(unitPrecision) == -1) {
             return false;

libreplan-business/src/main/java/org/libreplan/business/advance/entities/DirectAdvanceAssignment.java

@@ -223,7 +223,7 @@ public class DirectAdvanceAssignment extends AdvanceAssignment {
         return fake;
     }
 
-    @AssertTrue(message = "max value of percentage advance type must be 100")
+    @AssertTrue(message = "maxixum value of percentage progress type must be 100")
     public boolean checkConstraintMaxValueMustBe100ForPercentage() {
         AdvanceType advanceType = getAdvanceType();
         if ((advanceType != null) && (advanceType.getPercentage())) {
@@ -234,7 +234,7 @@ public class DirectAdvanceAssignment extends AdvanceAssignment {
         return true;
     }
 
-    @AssertTrue(message = "max value must be greater than zero")
+    @AssertTrue(message = "maximum value must be greater than zero")
     public boolean checkConstraintMaxValueMustBeGreaterThanZero() {
         return maxValue.compareTo(BigDecimal.ZERO) > 0;
     }

libreplan-business/src/main/java/org/libreplan/business/costcategories/entities/HourCost.java

@@ -150,7 +150,7 @@ public class HourCost extends IntegrationEntity {
         return (this.getEndDate() == null || !date.isAfter(this.getEndDate()));
     }
 
-    @AssertTrue(message="The end date cannot be before the init date")
+    @AssertTrue(message="The end date cannot be before the start date")
     public boolean checkPositiveTimeInterval() {
         if (initDate == null) {
             return true;

libreplan-business/src/main/java/org/libreplan/business/expensesheet/entities/ExpenseSheetLine.java

@@ -107,7 +107,7 @@ public class ExpenseSheetLine extends IntegrationEntity {
         this.orderElement = orderElement;
     }
 
-    @NotNull(message = "order element not specified")
+    @NotNull(message = "task not specified")
     public OrderElement getOrderElement() {
         return orderElement;
     }

libreplan-business/src/main/java/org/libreplan/business/externalcompanies/entities/CustomerCommunication.java

@@ -129,7 +129,7 @@ public class CustomerCommunication extends BaseEntity {
         this.order = order;
     }
 
-    @NotNull(message = "order not specified")
+    @NotNull(message = "project not specified")
     public Order getOrder() {
         return order;
     }

libreplan-business/src/main/java/org/libreplan/business/orders/entities/Order.java

@@ -346,7 +346,7 @@ public class Order extends OrderLineGroup implements Comparable {
     }
 
     @SuppressWarnings("unused")
-    @AssertTrue(message = "the order must have a start date")
+    @AssertTrue(message = "the project must have a start date")
     private boolean ifSchedulingModeIsForwardOrderMustHaveStartDate() {
         return getSchedulingMode() != SchedulingMode.FORWARD
                 || getInitDate() != null;
@@ -366,7 +366,7 @@ public class Order extends OrderLineGroup implements Comparable {
     }
 
     @SuppressWarnings("unused")
-    @AssertTrue(message = "At least one HoursGroup is needed for each OrderElement")
+    @AssertTrue(message = "At least one hours group is needed for each task")
     private boolean checkConstraintAtLeastOneHoursGroupForEachOrderElement() {
         for (OrderElement orderElement : this.getOrderElements()) {
             if (!orderElement.checkAtLeastOneHoursGroup()) {
@@ -420,7 +420,7 @@ public class Order extends OrderLineGroup implements Comparable {
         this.calendar = calendar;
     }
 
-    @NotNull(message = "order calendar not specified")
+    @NotNull(message = "project calendar not specified")
     public BaseCalendar getCalendar() {
         return calendar;
     }
@@ -432,7 +432,7 @@ public class Order extends OrderLineGroup implements Comparable {
         this.lastOrderElementSequenceCode++;
     }
 
-    @NotNull(message = "last order element sequence code not specified")
+    @NotNull(message = "last task sequence code not specified")
     public Integer getLastOrderElementSequenceCode() {
         return lastOrderElementSequenceCode;
     }

libreplan-business/src/main/java/org/libreplan/business/orders/entities/OrderElement.java

@@ -1429,7 +1429,7 @@ public abstract class OrderElement extends IntegrationEntity implements
         return getOrder() != null ? getOrder().isCodeAutogenerated() : false;
     }
 
-    @AssertTrue(message = "a quality form cannot be assigned twice to the same order element")
+    @AssertTrue(message = "a quality form cannot be assigned twice to the same task")
     public boolean checkConstraintUniqueQualityForm() {
         Set<QualityForm> qualityForms = new HashSet<QualityForm>();
         for (TaskQualityForm each : taskQualityForms) {

libreplan-business/src/main/java/org/libreplan/business/orders/entities/OrderLineGroup.java

@@ -1137,7 +1137,7 @@ public class OrderLineGroup extends OrderElement implements
         return result;
     }
 
-    @AssertTrue(message = "indirect advance assignments should have different types")
+    @AssertTrue(message = "indirect progress assignments should have different types")
     public boolean checkConstraintIndirectAdvanceAssignmentsWithDifferentType() {
         Set<String> types = new HashSet<String>();
         for (IndirectAdvanceAssignment each : indirectAdvanceAssignments) {

libreplan-business/src/main/java/org/libreplan/business/planner/entities/Task.java

@@ -168,7 +168,7 @@ public class Task extends TaskElement implements ITaskPositionConstrained {
     }
 
     @SuppressWarnings("unused")
-    @AssertTrue(message = "order element associated to a task must be not empty")
+    @AssertTrue(message = "element associated to a task must be not empty")
     private boolean theOrderElementMustBeNotNull() {
         return getOrderElement() != null;
     }

libreplan-business/src/main/java/org/libreplan/business/planner/entities/TaskGroup.java

@@ -107,7 +107,7 @@ public class TaskGroup extends TaskElement {
     }
 
     @SuppressWarnings("unused")
-    @AssertTrue(message = "order element associated to a task group have to be defined")
+    @AssertTrue(message = "element associated to a task group have to be defined")
     private boolean theOrderElementMustBeNotNull() {
         return getOrderElement() != null;
     }

libreplan-business/src/main/java/org/libreplan/business/qualityforms/entities/QualityForm.java

@@ -386,7 +386,7 @@ public class QualityForm extends BaseEntity implements IHumanIdentifiable{
         return (position >= 0 && position < qualityFormItems.size());
     }
 
-    @NotNull(message = "report advance not specified")
+    @NotNull(message = "report progress not specified")
     public Boolean isReportAdvance() {
         return BooleanUtils.toBoolean(reportAdvance);
     }
@@ -403,7 +403,7 @@ public class QualityForm extends BaseEntity implements IHumanIdentifiable{
         this.advanceType = advanceType;
     }
 
-    @AssertTrue(message = "advance type should not be null if report advance")
+    @AssertTrue(message = "progress type should must be defined if quality form reports progress")
     public boolean checkConstraintAdvanceTypeIsNotNullIfReportAdvance() {
         if (advanceType == null) {
             return !isReportAdvance();

libreplan-business/src/main/java/org/libreplan/business/qualityforms/entities/TaskQualityForm.java

@@ -69,7 +69,7 @@ public class TaskQualityForm extends BaseEntity {
         this.taskQualityFormItems = taskQualityFormItems;
     }
 
-    @NotNull(message = "order element not specified")
+    @NotNull(message = "task not specified")
     public OrderElement getOrderElement() {
         return orderElement;
     }
@@ -168,7 +168,7 @@ public class TaskQualityForm extends BaseEntity {
         return true;
     }
 
-    @NotNull(message = "report advance not specified")
+    @NotNull(message = "report progress not specified")
     public Boolean isReportAdvance() {
         return BooleanUtils.toBoolean(reportAdvance);
     }

libreplan-business/src/main/java/org/libreplan/business/resources/entities/MachineWorkersConfigurationUnit.java

@@ -171,7 +171,7 @@ public class MachineWorkersConfigurationUnit extends BaseEntity implements
         return (this.alpha.compareTo(new BigDecimal(0)) > 0);
     }
 
-    @AssertTrue(message = "All Machine worker assignments must have a start date earlier than the finish date")
+    @AssertTrue(message = "All machine worker assignments must have a start date earlier than the end date")
     public boolean checkWorkerAssignmentsIntervalsProperlyDefined() {
         boolean correctIntervals = true;
         for (MachineWorkerAssignment each : workerAssignments) {

libreplan-business/src/main/java/org/libreplan/business/workreports/entities/WorkReport.java

@@ -457,7 +457,7 @@ public class WorkReport extends IntegrationEntity implements
         lastWorkReportLineSequenceCode++;
     }
 
-    @NotNull(message = "last order element sequence code not specified")
+    @NotNull(message = "last timesheet line sequence code not specified")
     public Integer getLastWorkReportLineSequenceCode() {
         return lastWorkReportLineSequenceCode;
     }

libreplan-business/src/main/java/org/libreplan/business/workreports/entities/WorkReportLine.java

@@ -173,7 +173,7 @@ public class WorkReportLine extends IntegrationEntity implements Comparable,
     }
 
     @Override
-    @NotNull(message = "order element not specified")
+    @NotNull(message = "task not specified")
     public OrderElement getOrderElement() {
         return orderElement;
     }

libreplan-webapp/src/main/java/org/libreplan/web/costcategories/CostCategoryCRUDController.java

@@ -342,7 +342,7 @@ public class CostCategoryCRUDController extends BaseCRUDController<CostCategory>
     private void appendDateboxInitDate(final Row row) {
         Datebox initDateBox = new Datebox();
         bindDateboxInitDate(initDateBox, (HourCost) row.getValue());
-        initDateBox.setConstraint("no empty:" + _("Init date cannot be empty"));
+        initDateBox.setConstraint("no empty:" + _("Start date cannot be empty"));
         row.appendChild(initDateBox);
 
         initDateBox.addEventListener("onChange", new EventListener() {

libreplan-webapp/src/main/java/org/libreplan/web/costcategories/ResourcesCostCategoryAssignmentController.java

@@ -177,7 +177,7 @@ public class ResourcesCostCategoryAssignmentController extends GenericForwardCom
     private void appendDateboxInitDate(final Row row) {
         Datebox initDateBox = new Datebox();
         bindDateboxInitDate(initDateBox, (ResourcesCostCategoryAssignment) row.getValue());
-        initDateBox.setConstraint("no empty:" + _("Init date cannot be empty"));
+        initDateBox.setConstraint("no empty:" + _("Start date cannot be empty"));
         row.appendChild(initDateBox);
 
         initDateBox.addEventListener("onChange", new EventListener() {

libreplan-webapp/src/main/java/org/libreplan/web/orders/OrderCRUDController.java

@@ -1335,7 +1335,7 @@ public class OrderCRUDController extends GenericForwardComposer {
                         && (startDate.compareTo(filterFinishDate.getValue()) > 0)) {
                     filterStartDate.setValue(null);
                     throw new WrongValueException(comp,
-                            _("must be lower than finish date"));
+                            _("must be lower than end date"));
                 }
             }
         };

libreplan-webapp/src/main/java/org/libreplan/web/orders/OrderElementTreeController.java

@@ -692,7 +692,7 @@ public class OrderElementTreeController extends TreeController<OrderElement> {
                                 .getValue()) > 0)) {
                     filterStartDateOrderElement.setValue(null);
                     throw new WrongValueException(comp,
-                            _("must be lower than finish date"));
+                            _("must be lower than end date"));
                 }
             }
         };

libreplan-webapp/src/main/java/org/libreplan/web/orders/OrdersTreeComponent.java

@@ -89,7 +89,7 @@ public class OrdersTreeComponent extends TreeComponent {
         });
         columns.add(new OrdersTreeColumn(_("Must start after"),
                         "estimated_init",
-                        _("Estimated init date for the task (press enter in textbox to open calendar popup or type in date directly)")) {
+                        _("Estimated start date for the task (press enter in textbox to open calendar popup or type in date directly)")) {
 
             @Override
             protected void doCell(OrderElementTreeitemRenderer treeRenderer,

libreplan-webapp/src/main/java/org/libreplan/web/orders/ProjectDetailsController.java

@@ -250,7 +250,7 @@ public class ProjectDetailsController extends GenericForwardComposer {
                     initDate.setValue(null);
                     getOrder().setInitDate(null);
                     throw new WrongValueException(comp,
-                            _("must be lower than finish date"));
+                            _("must be lower than end date"));
                 }
             }
         };

libreplan-webapp/src/main/java/org/libreplan/web/planner/company/CompanyPlanningController.java

@@ -272,7 +272,7 @@ public class CompanyPlanningController implements Composer {
                                 filterFinishDate.getRawValue()) > 0)) {
                     filterStartDate.setValue(null);
                     throw new WrongValueException(comp,
-                            _("must be lower than finish date"));
+                            _("must be lower than end date"));
                 }
             }
         };

libreplan-webapp/src/main/java/org/libreplan/web/planner/order/OrderPlanningController.java

@@ -341,7 +341,7 @@ public class OrderPlanningController implements Composer {
                                 .getValue()) > 0)) {
                     filterStartDateOrderElement.setValue(null);
                     throw new WrongValueException(comp,
-                            _("must be lower than finish date"));
+                            _("must be lower than end date"));
                 }
             }
         };

libreplan-webapp/src/main/java/org/libreplan/web/reports/OrderCostsPerResourceController.java

@@ -142,7 +142,7 @@ public class OrderCostsPerResourceController extends LibrePlanReportController {
                         && (startDateLine.compareTo(getEndingDate()) > 0)) {
                     ((Datebox) comp).setValue(null);
                     throw new WrongValueException(comp,
-                            _("must be lower than finish date"));
+                            _("must be lower than end date"));
                 }
             }
         };
@@ -158,7 +158,7 @@ public class OrderCostsPerResourceController extends LibrePlanReportController {
                         && (endingDate.compareTo(getStartingDate()) < 0)) {
                     ((Datebox) comp).setValue(null);
                     throw new WrongValueException(comp,
-                            _("must be after finish date"));
+                            _("must be after end date"));
                 }
             }
         };

libreplan-webapp/src/main/java/org/libreplan/web/resources/machine/MachineCRUDController.java

@@ -422,7 +422,7 @@ public class MachineCRUDController extends BaseCRUDController<Machine> {
                         && (startDate.compareTo(filterFinishDate.getValue()) > 0)) {
                     filterStartDate.setValue(null);
                     throw new WrongValueException(comp,
-                            _("must be lower than finish date"));
+                            _("must be lower than end date"));
                 }
             }
         };

libreplan-webapp/src/main/java/org/libreplan/web/resources/worker/WorkerCRUDController.java

@@ -782,7 +782,7 @@ public class WorkerCRUDController extends GenericForwardComposer implements
                         && (startDate.compareTo(filterFinishDate.getValue()) > 0)) {
                     filterStartDate.setValue(null);
                     throw new WrongValueException(comp,
-                            _("must be lower than finish date"));
+                            _("must be lower than end date"));
                 }
             }
         };

libreplan-webapp/src/main/java/org/libreplan/web/workreports/WorkReportCRUDController.java

@@ -1517,7 +1517,7 @@ public class WorkReportCRUDController extends GenericForwardComposer implements
                         && (startDate.compareTo(filterFinishDate.getValue()) > 0)) {
                     filterStartDate.setValue(null);
                     throw new WrongValueException(comp,
-                            _("must be before finish date"));
+                            _("must be before end date"));
                 }
             }
         };

libreplan-webapp/src/main/java/org/libreplan/web/workreports/WorkReportQueryController.java

@@ -153,7 +153,7 @@ public class WorkReportQueryController extends GenericForwardComposer {
                                 .getValue()) > 0)) {
                     filterStartDateLine.setValue(null);
                     throw new WrongValueException(comp,
-                            _("must be lower than finish date"));
+                            _("must be lower than end date"));
                 }
             }
         };

libreplan-webapp/src/main/webapp/costcategories/_editCostCategory.zul

@@ -78,7 +78,7 @@
                                     <column label="${i18n:_('Code')}" align="center"/>
                                     <column label="${i18n:_('Type')}" align="center"/>
                                     <column label="${i18n:_('Price per hour')}" align="center"/>
-                                    <column label="${i18n:_('Init date')}" align="center"/>
+                                    <column label="${i18n:_('Start date')}" align="center"/>
                                     <column label="${i18n:_('End date')}" align="center"/>
                                     <column label="${i18n:_('Operations')}" width="150px" align="center"/>
                                 </columns>

libreplan-webapp/src/main/webapp/excetiondays/_listExceptionDayTypes.zul

@@ -19,7 +19,7 @@
   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 -->
 
-<window id="${arg.id}" title="${i18n:_('Exception Day Types List')}">
+<window id="${arg.id}">
 
     <newdatasortablegrid id="listExceptionDayTypes"
         model="@{controller.exceptionDayTypes}"

libreplan-webapp/src/main/webapp/resources/_costCategoryAssignment.zul

@@ -34,7 +34,7 @@
                     rowRenderer="@{assignmentController.costCategoryAssignmentsRenderer}">
                 <columns>
                     <column label="${i18n:_('Category name')}" align="center"/>
-                    <column label="${i18n:_('Init date')}" align="center"/>
+                    <column label="${i18n:_('Start date')}" align="center"/>
                     <column label="${i18n:_('End date')}" align="center"/>
                     <column label="${i18n:_('Operations')}" width="150px" align="center"/>
                 </columns>

libreplan-webapp/src/main/webapp/unittypes/_editUnitType.zul

@@ -48,7 +48,7 @@
                             </hbox>
                         </row>
                         <row>
-                            <label value="${i18n:_('Unit measure name')}" />
+                            <label value="${i18n:_('Name')}" />
                             <textbox
                                 id="measureTextBox"
                                 value="@{controller.unitType.measure}"

libreplan-webapp/src/main/webapp/unittypes/_listUnitTypes.zul

@@ -19,12 +19,12 @@
   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 -->
 
-<window id="${arg.top_id}" title="${i18n:_('Unit Measures List')}">
+<window id="${arg.top_id}">
     <newdatasortablegrid id="listing" model="@{controller.unitTypes}" mold="paging"
         pageSize="10" fixedLayout="true" sclass="clickable-rows"
         rowRenderer="@{controller.unitTypeRenderer}" >
         <columns>
-            <newdatasortablecolumn label="${i18n:_('Unit Measure')}"
+            <newdatasortablecolumn label="${i18n:_('Material Unit')}"
             sortDirection="ascending" sort="auto(measure)"/>
             <newdatasortablecolumn label="${i18n:_('Operations')}"/>
         </columns>