RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid executing methods twice

Browse source 
Extract local variables so potentially expensive methods are not executed twice

FEA: ItEr69S10CriteriaLoadRefinement
This commit is contained in:
Óscar González Fernández 2011-02-02 20:24:31 +01:00
parent 55ad1b571b
commit 1fd1462b89
1 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
navalplanner-webapp/src/main/java/org/navalplanner/web/resourceload/LoadPeriodGenerator.java
View file

@ -206,20 +206,21 @@ abstract class LoadPeriodGenerator {
+ allocationsOnInterval + ". LoadPeriod ignored");
return null;
}
return new LoadPeriod(start, end, getTotalWorkHours(),
getHoursAssigned(), new LoadLevel(
calculateLoadPercentage()));
int totalWorkHours = getTotalWorkHours();
int hoursAssigned = getHoursAssigned();
return new LoadPeriod(start, end, totalWorkHours, hoursAssigned,
new LoadLevel(calculateLoadPercentage(totalWorkHours,
hoursAssigned)));
}
protected abstract int getTotalWorkHours();
private int calculateLoadPercentage() {
final int totalResourceWorkHours = getTotalWorkHours();
int assigned = getHoursAssigned();
if (totalResourceWorkHours == 0) {
return assigned == 0 ? 0 : Integer.MAX_VALUE;
private static int calculateLoadPercentage(int totalWorkHours,
int hoursAssigned) {
if (totalWorkHours == 0) {
return hoursAssigned == 0 ? 0 : Integer.MAX_VALUE;
}
double proportion = assigned / (double) totalResourceWorkHours;
double proportion = hoursAssigned / (double) totalWorkHours;
return new BigDecimal(proportion).scaleByPowerOfTen(2).intValue();
}