RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Bug #987] Pretty print ValidationExceptions as WrongValueExceptions in CostCategories

Browse source 
FEA: ItEr74S04BugFixing
This commit is contained in:
Diego Pino Garcia 2011-05-03 08:36:35 +02:00
parent 6360d2eacb
commit 26c1bbdb68
1 changed files with 32 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
navalplanner-webapp/src/main/java/org/navalplanner/web/costcategories/CostCategoryCRUDController.java
View file

@ -192,12 +192,42 @@ public class CostCategoryCRUDController extends GenericForwardComposer
messagesForUser.showMessage(Level.INFO, _("Cost category saved"));
return true;
} catch (ValidationException e) {
e.getInvalidValue().getValue();
messagesForUser.showInvalidValues(e);
showInvalidValues(e);
}
return false;
}
private void showInvalidValues(ValidationException e) {
Object value = e.getInvalidValue().getBean();
if (value instanceof HourCost) {
showInvalidValue((HourCost) value);
}
messagesForUser.showInvalidValues(e);
}
private void showInvalidValue(HourCost hourCost) {
Row row = ComponentsFinder.findRowByValue(listHourCosts, hourCost);
if (row != null) {
if (hourCost.getType() == null) {
Listbox workHoursType = getWorkHoursType(row);
String message = workHoursType.getItems().isEmpty() ? _("Type of hours is empty. Please, create some type of hours before proceeding")
: _("The type of hours cannot be null");
throw new WrongValueException(getWorkHoursType(row), message);
}
if (hourCost.getPriceCost() == null) {
throw new WrongValueException(getPricePerHour(row), _("Cannot be null or empty"));
}
}
}
private Listbox getWorkHoursType(Row row) {
return (Listbox) row.getChildren().get(1);
}
private Component getPricePerHour(Row row) {
return (Component) row.getChildren().get(2);
}
public CostCategory getCostCategory() {
return costCategoryModel.getCostCategory();
}