RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixing problem with order code validation in subcontract service.

Browse source 
* The order code has been validated before the new code was generated.
* Commented out the lines doing the validation and marking as FIXME to review in the future.

FEA: ItEr62S05BugFixing
This commit is contained in:
Manuel Rego Casasnovas 2010-10-22 09:42:01 +02:00
parent 77bee14fdb
commit 2d102d234f
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
navalplanner-webapp/src/main/java/org/navalplanner/ws/common/impl/OrderElementConverter.java
View file

@ -252,9 +252,12 @@ public final class OrderElementConverter {
}
OrderElement orderElement = toEntityExceptCriterionRequirements(
orderVersion, orderElementDTO, configuration);
// FIXME Review why this validation is needed here, it breaks the
// subcontract service. This was introduced at commit 341145a5
// Validate OrderElement.code and HoursGroup.code must be unique
Order.checkConstraintOrderUniqueCode(orderElement);
HoursGroup.checkConstraintHoursGroupUniqueCode(orderElement);
// Order.checkConstraintOrderUniqueCode(orderElement);
// HoursGroup.checkConstraintHoursGroupUniqueCode(orderElement);
if (configuration.isCriterionRequirements()) {
addOrCriterionRequirements(orderElement, orderElementDTO);