From 2d5891c64cf3750164b663774de3be2ff7331109 Mon Sep 17 00:00:00 2001
From: Manuel Rego Casasnovas <rego@igalia.com>
Date: Tue, 3 Jul 2012 09:20:51 +0200
Subject: [PATCH] Bug #1473: Using OrderVersion from project in updating

Take advantage to remove some unneeded printStackTrace calls.

FEA: ItEr76S04BugFixing
---
 .../ws/common/impl/OrderElementConverter.java        | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/libreplan-webapp/src/main/java/org/libreplan/ws/common/impl/OrderElementConverter.java b/libreplan-webapp/src/main/java/org/libreplan/ws/common/impl/OrderElementConverter.java
index 3c862be74..926d4e2ef 100644
--- a/libreplan-webapp/src/main/java/org/libreplan/ws/common/impl/OrderElementConverter.java
+++ b/libreplan-webapp/src/main/java/org/libreplan/ws/common/impl/OrderElementConverter.java
@@ -577,6 +577,7 @@ public final class OrderElementConverter {
                 }
             }
         } else { // orderElementDTO instanceof OrderLineGroupDTO
+            OrderVersion orderVersion = null;
             if (orderElementDTO instanceof OrderDTO) {
                 if (!(orderElement instanceof Order)) {
                     throw new ValidationException(MessageFormat.format(
@@ -586,7 +587,7 @@ public final class OrderElementConverter {
 
                 }
                 Order order = (Order) orderElement;
-                OrderVersion orderVersion = order.getOrderVersionFor(Registry
+                orderVersion = order.getOrderVersionFor(Registry
                         .getScenarioManager()
                         .getCurrent());
                 order.useSchedulingDataFor(orderVersion);
@@ -636,8 +637,8 @@ public final class OrderElementConverter {
                                 "Hours Group {0}: Duplicate code in DB",
                                 childDTO.code));
                     }
-                    ((OrderLineGroup) orderElement).add(toEntity(childDTO,
-                            configuration));
+                    ((OrderLineGroup) orderElement).add(toEntity(orderVersion,
+                            childDTO, configuration));
                 }
             }
 
@@ -710,9 +711,8 @@ public final class OrderElementConverter {
                     .findByCode(orderElement.code);
             return existsByCode != null;
         } catch (InstanceNotFoundException e) {
-            e.printStackTrace();
+            return false;
         }
-        return false;
     }
 
     /**
@@ -739,7 +739,7 @@ public final class OrderElementConverter {
                 }
             }
         } catch (InstanceNotFoundException e) {
-            e.printStackTrace();
+            // Do nothing
         }
         return false;
     }