From 33054a489900384ff31f9b8c0b77d6cde456348e Mon Sep 17 00:00:00 2001 From: Nacho Barrientos Date: Tue, 22 Nov 2011 18:01:06 +0100 Subject: [PATCH] Extract local variables to class static attributes. FEA: ItEr75S27PerProjectDashboard --- .../web/dashboard/DashboardModel.java | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/libreplan-webapp/src/main/java/org/libreplan/web/dashboard/DashboardModel.java b/libreplan-webapp/src/main/java/org/libreplan/web/dashboard/DashboardModel.java index 9ce254b65..9b8e22e5a 100644 --- a/libreplan-webapp/src/main/java/org/libreplan/web/dashboard/DashboardModel.java +++ b/libreplan-webapp/src/main/java/org/libreplan/web/dashboard/DashboardModel.java @@ -51,11 +51,18 @@ import org.springframework.stereotype.Component; @Scope(BeanDefinition.SCOPE_PROTOTYPE) public class DashboardModel { + /* Parameters */ public final static int EA_STRETCHES_PERCENTAGE_STEP = 10; public final static int EA_STRETCHES_MIN_VALUE = -100; public final static int EA_STRETCHES_MAX_VALUE = 150; public final static int LTC_NUMBER_OF_INTERVALS = 10; + /* To be calculated */ + public static double LTC_STRETCHES_STEP = 0; + public static double LTC_STRETCHES_MIN_VALUE = 0; + public static double LTC_STRETCHES_MAX_VALUE = 0; + + private Order currentOrder; private Integer taskCount = null; @@ -225,12 +232,14 @@ public class DashboardModel { rootTask.acceptVisitor(visitor); List deviations = visitor.getDeviations(); - Double minDeviation = Collections.min(deviations); - Double maxDeviation = Collections.max(deviations); + LTC_STRETCHES_MIN_VALUE = Collections.min(deviations); + LTC_STRETCHES_MAX_VALUE = Collections.max(deviations); + LTC_STRETCHES_STEP = (LTC_STRETCHES_MAX_VALUE - LTC_STRETCHES_MIN_VALUE) + /LTC_NUMBER_OF_INTERVALS; this.lagInTaskCompletionHistogram = createHistogram( - Collections.min(deviations), - Collections.max(deviations), - (maxDeviation - minDeviation)/LTC_NUMBER_OF_INTERVALS, + LTC_STRETCHES_MIN_VALUE, + LTC_STRETCHES_MAX_VALUE, + LTC_STRETCHES_STEP, deviations); }