From 33b23b341b9fe2f1a9df86a80e06d08c68e17693 Mon Sep 17 00:00:00 2001 From: Manuel Rego Casasnovas Date: Tue, 15 Feb 2011 23:30:06 +0100 Subject: [PATCH] [Bug #848] Removed repeated method in OrderLineGroup. FEA: ItEr70S04BugFixing --- .../business/orders/entities/OrderLineGroup.java | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/navalplanner-business/src/main/java/org/navalplanner/business/orders/entities/OrderLineGroup.java b/navalplanner-business/src/main/java/org/navalplanner/business/orders/entities/OrderLineGroup.java index f08a8c0bc..6d3ece7e6 100644 --- a/navalplanner-business/src/main/java/org/navalplanner/business/orders/entities/OrderLineGroup.java +++ b/navalplanner-business/src/main/java/org/navalplanner/business/orders/entities/OrderLineGroup.java @@ -823,7 +823,8 @@ public class OrderLineGroup extends OrderElement implements public void addIndirectAdvanceAssignment( IndirectAdvanceAssignment indirectAdvanceAssignment) { - if (!existsIndirectAdvanceAssignmentWithTheSameType(indirectAdvanceAssignment)) { + if (!existsIndirectAdvanceAssignmentWithTheSameType(indirectAdvanceAssignment + .getAdvanceType())) { indirectAdvanceAssignments.add(indirectAdvanceAssignment); } if (parent != null) { @@ -863,19 +864,6 @@ public class OrderLineGroup extends OrderElement implements } } - private boolean existsIndirectAdvanceAssignmentWithTheSameType( - IndirectAdvanceAssignment newIndirectAdvanceAssignment) { - String unitName = newIndirectAdvanceAssignment.getAdvanceType() - .getUnitName(); - for (IndirectAdvanceAssignment indirectAdvanceAssignment : indirectAdvanceAssignments) { - if (unitName.equals(indirectAdvanceAssignment.getAdvanceType() - .getUnitName())) { - return true; - } - } - return false; - } - public boolean existsIndirectAdvanceAssignmentWithTheSameType( AdvanceType type) { String unitName = type.getUnitName();