RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ItEr28S14RFVistaGraficaInformacionAvance: Refactoring method name from "getLastPercentage()" to "getAdvancePercentage()".

Browse source
This commit is contained in:
Manuel Rego Casasnovas 2009-10-01 13:09:13 +02:00 • committed by Javier Moran Rua
parent bd303482f8
commit 3f8a18915d
4 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
navalplanner-business/src/main/java/org/navalplanner/business/advance/entities/DirectAdvanceAssignment.java
View file

@ -74,7 +74,7 @@ public class DirectAdvanceAssignment extends AdvanceAssignment {
return advanceMeasurements.first();
}
public BigDecimal getLastPercentage() {
public BigDecimal getAdvancePercentage() {
if (maxValue.compareTo(BigDecimal.ZERO) == 0) {
return BigDecimal.ZERO;
}

2
navalplanner-business/src/main/java/org/navalplanner/business/orders/entities/OrderLine.java
View file

@ -354,7 +354,7 @@ public class OrderLine extends OrderElement {
for (DirectAdvanceAssignment directAdvanceAssignment : directAdvanceAssignments) {
if (directAdvanceAssignment.getReportGlobalAdvance()) {
if (date == null) {
return directAdvanceAssignment.getLastPercentage();
return directAdvanceAssignment.getAdvancePercentage();
}
return directAdvanceAssignment.getAdvancePercentage(date);
}

4
navalplanner-business/src/main/java/org/navalplanner/business/orders/entities/OrderLineGroup.java
View file

@ -181,7 +181,7 @@ public class OrderLineGroup extends OrderElement implements IOrderLineGroup {
for (DirectAdvanceAssignment directAdvanceAssignment : directAdvanceAssignments) {
if (directAdvanceAssignment.getReportGlobalAdvance()) {
if (date == null) {
return directAdvanceAssignment.getLastPercentage();
return directAdvanceAssignment.getAdvancePercentage();
}
return directAdvanceAssignment.getAdvancePercentage(date);
}
@ -198,7 +198,7 @@ public class OrderLineGroup extends OrderElement implements IOrderLineGroup {
} else {
DirectAdvanceAssignment directAdvanceAssignment = calculateFakeDirectAdvanceAssignment(indirectAdvanceAssignment);
if (date == null) {
return directAdvanceAssignment.getLastPercentage();
return directAdvanceAssignment.getAdvancePercentage();
}
return directAdvanceAssignment.getAdvancePercentage(date);
}

4
navalplanner-business/src/test/java/org/navalplanner/business/test/orders/entities/OrderElementTest.java
View file

@ -910,7 +910,7 @@ public class OrderElementTest {
equalTo(3));
assertThat(advanceAssignment.getLastAdvanceMeasurement().getValue(),
equalTo(new BigDecimal(5000)));
assertThat(advanceAssignment.getLastPercentage(),
assertThat(advanceAssignment.getAdvancePercentage(),
equalTo(new BigDecimal(45).divide(new BigDecimal(100))
.setScale(2)));
}
@ -957,7 +957,7 @@ public class OrderElementTest {
equalTo(3));
assertThat(advanceAssignment.getLastAdvanceMeasurement().getValue(),
equalTo(new BigDecimal(5000)));
assertThat(advanceAssignment.getLastPercentage(),
assertThat(advanceAssignment.getAdvancePercentage(),
equalTo(new BigDecimal(45).divide(new BigDecimal(100))
.setScale(2)));
}