RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Bug #1065] Fixed issue adding method to open a new transaction on DAO.

Browse source 
* Added method findUniqueByNameAnotherTransaction to
  CalendarExceptionTypeDAO.
* Renamed method findByName to findUniqueByName in
  CalendarExceptionTypeDAO.

FEA: ItEr74S04BugFixing
This commit is contained in:
Manuel Rego Casasnovas 2011-05-11 10:21:51 +02:00
parent 41c357a3c3
commit 408686138f
3 changed files with 15 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
navalplanner-business/src/main/java/org/navalplanner/business/calendars/daos/CalendarExceptionTypeDAO.java
View file

@ -82,7 +82,7 @@ public class CalendarExceptionTypeDAO extends
@Override
public boolean existsByName(String name) {
try {
findByName(name);
findUniqueByName(name);
return true;
} catch (InstanceNotFoundException e) {
return false;
@ -91,7 +91,7 @@ public class CalendarExceptionTypeDAO extends
@Override
@Transactional(readOnly = true)
public CalendarExceptionType findByName(String name) throws InstanceNotFoundException {
public CalendarExceptionType findUniqueByName(String name) throws InstanceNotFoundException {
if (StringUtils.isBlank(name)) {
throw new InstanceNotFoundException(null, CalendarExceptionType.class.getName());
}
@ -109,4 +109,11 @@ public class CalendarExceptionTypeDAO extends
}
@Override
@Transactional(readOnly = true, propagation = Propagation.REQUIRES_NEW)
public CalendarExceptionType findUniqueByNameAnotherTransaction(String name)
throws InstanceNotFoundException {
return findUniqueByName(name);
}
}

5
navalplanner-business/src/main/java/org/navalplanner/business/calendars/daos/ICalendarExceptionTypeDAO.java
View file

@ -44,8 +44,11 @@ public interface ICalendarExceptionTypeDAO extends
boolean existsByNameAnotherTransaction(String name);
CalendarExceptionType findByName(String name) throws InstanceNotFoundException;
CalendarExceptionType findUniqueByName(String name) throws InstanceNotFoundException;
boolean existsByName(String name);
CalendarExceptionType findUniqueByNameAnotherTransaction(String name)
throws InstanceNotFoundException;
}

3
navalplanner-business/src/main/java/org/navalplanner/business/calendars/entities/CalendarExceptionType.java
View file

@ -167,7 +167,8 @@ public class CalendarExceptionType extends IntegrationEntity {
name);
} else {
try {
CalendarExceptionType calendarExceptionType = calendarExceptionTypeDAO.findByName(name);
CalendarExceptionType calendarExceptionType = calendarExceptionTypeDAO
.findUniqueByNameAnotherTransaction(name);
return calendarExceptionType.getId().equals(getId());
} catch (InstanceNotFoundException e) {
return true;