From 4600b572ab8a3f0ed9e5573eca557720f5f96519 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=93scar=20Gonz=C3=A1lez=20Fern=C3=A1ndez?= Date: Sat, 7 Nov 2009 19:53:14 +0100 Subject: [PATCH] ItEr33S14CUCreacionUnidadesPlanificacion: Renaming method and variables to show better intent --- ganttzk/src/main/java/org/zkoss/ganttz/data/Task.java | 7 ++++--- .../web/planner/allocation/ResourceAllocationModel.java | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/ganttzk/src/main/java/org/zkoss/ganttz/data/Task.java b/ganttzk/src/main/java/org/zkoss/ganttz/data/Task.java index 8fe1bc22f..0d24d77d7 100644 --- a/ganttzk/src/main/java/org/zkoss/ganttz/data/Task.java +++ b/ganttzk/src/main/java/org/zkoss/ganttz/data/Task.java @@ -118,10 +118,11 @@ public abstract class Task implements ITaskFundamentalProperties { return fundamentalProperties.getLengthMilliseconds(); } - public void fireChangesForOldValues(Date oldBegin, long oldLength) { + public void fireChangesForPreviousValues(Date previousStart, + long previousLength) { fundamentalPropertiesListeners.firePropertyChange("beginDate", - oldBegin, fundamentalProperties.getBeginDate()); - fireLengthMilliseconds(oldLength); + previousStart, fundamentalProperties.getBeginDate()); + fireLengthMilliseconds(previousLength); } public Date getBeginDate() { diff --git a/navalplanner-webapp/src/main/java/org/navalplanner/web/planner/allocation/ResourceAllocationModel.java b/navalplanner-webapp/src/main/java/org/navalplanner/web/planner/allocation/ResourceAllocationModel.java index 0b5ba8dd6..31781f800 100644 --- a/navalplanner-webapp/src/main/java/org/navalplanner/web/planner/allocation/ResourceAllocationModel.java +++ b/navalplanner-webapp/src/main/java/org/navalplanner/web/planner/allocation/ResourceAllocationModel.java @@ -128,10 +128,11 @@ public class ResourceAllocationModel implements IResourceAllocationModel { } private void doTheAllocation(AllocationResult allocationResult) { - Date oldBeginDate = ganttTask.getBeginDate(); - long oldLength = ganttTask.getLengthMilliseconds(); + Date previousStartDate = ganttTask.getBeginDate(); + long previousLength = ganttTask.getLengthMilliseconds(); allocationResult.applyTo(task); - ganttTask.fireChangesForOldValues(oldBeginDate, oldLength); + ganttTask.fireChangesForPreviousValues(previousStartDate, + previousLength); } private List getResourcesMatchingCriterions() {