RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

jira-integration: Simplify code in updateOrCreateDescriptionValuesAndAddToWorkReportLine

Browse source 
As we know that the predefined WorkReportType will only have 1 DescriptionValue,
we can take advantage of this to simplify the code.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
This commit is contained in:
Manuel Rego Casasnovas 2013-01-30 17:43:38 +01:00
parent e16ec15add
commit 4cd0afc504
1 changed files with 11 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
libreplan-webapp/src/main/java/org/libreplan/importers/JiraTimesheetSynchronizer.java
View file

@ -19,7 +19,6 @@
package org.libreplan.importers;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
@ -243,21 +242,18 @@ public class JiraTimesheetSynchronizer implements IJiraTimesheetSynchronizer {
*/
private void updateOrCreateDescriptionValuesAndAddToWorkReportLine(WorkReportLine workReportLine,
String comment) {
Set<DescriptionValue> descriptionValues = new HashSet<DescriptionValue>();
for (DescriptionField descriptionField : workReportType.getLineFields()) {
DescriptionValue descriptionValue;
try {
descriptionValue = workReportLine
.getDescriptionValueByFieldName(descriptionField
.getFieldName());
descriptionValue.setValue(comment.substring(0,
Math.min(comment.length(), 254)));
} catch (InstanceNotFoundException e) {
descriptionValue = DescriptionValue.create(
descriptionField.getFieldName(), comment);
}
descriptionValues.add(descriptionValue);
DescriptionField descriptionField = workReportType.getLineFields().iterator().next();
comment = comment.substring(0, descriptionField.getLength() - 1);
Set<DescriptionValue> descriptionValues = workReportLine
.getDescriptionValues();
if (descriptionValues.isEmpty()) {
descriptionValues.add(DescriptionValue.create(
descriptionField.getFieldName(), comment));
} else {
descriptionValues.iterator().next().setValue(comment);
}
workReportLine.setDescriptionValues(descriptionValues);
}