From a4b1f3bc1490a6af7307dc21111a148ae8b9453d Mon Sep 17 00:00:00 2001 From: lmann99 Date: Thu, 26 Jan 2017 00:46:46 -0500 Subject: [PATCH 1/2] Correct index out of bounds exception in focusGoDown Adds a check to prevent list index from going negative Fixes#17 --- .../src/main/java/org/libreplan/web/tree/TreeController.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libreplan-webapp/src/main/java/org/libreplan/web/tree/TreeController.java b/libreplan-webapp/src/main/java/org/libreplan/web/tree/TreeController.java index 69ad4ebcc..fe710ea38 100644 --- a/libreplan-webapp/src/main/java/org/libreplan/web/tree/TreeController.java +++ b/libreplan-webapp/src/main/java/org/libreplan/web/tree/TreeController.java @@ -609,7 +609,7 @@ public abstract class TreeController> extends GenericForw int myPosition = parent.getIndex(); - if (myPosition < treeItems.size() - 1) { + if ((myPosition < treeItems.size() - 1) && myPosition > -1) { // The current node is not the last one Treerow downTreerow = treeItems.get(myPosition + 1).getTreerow(); From 737967c2f8f8b614f999f5ce5ff07e61eb87ffe9 Mon Sep 17 00:00:00 2001 From: lmann99 Date: Thu, 26 Jan 2017 00:46:46 -0500 Subject: [PATCH 2/2] Correct index out of bounds exception in focusGoDown Adds a check to stop treeList at the second last item instead of allowing the list index to go negative. Fixes#17 --- .../src/main/java/org/libreplan/web/tree/TreeController.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libreplan-webapp/src/main/java/org/libreplan/web/tree/TreeController.java b/libreplan-webapp/src/main/java/org/libreplan/web/tree/TreeController.java index 69ad4ebcc..7640a01e4 100644 --- a/libreplan-webapp/src/main/java/org/libreplan/web/tree/TreeController.java +++ b/libreplan-webapp/src/main/java/org/libreplan/web/tree/TreeController.java @@ -609,7 +609,7 @@ public abstract class TreeController> extends GenericForw int myPosition = parent.getIndex(); - if (myPosition < treeItems.size() - 1) { + if ((myPosition < treeItems.size() - 1) && myPosition > 0) { // The current node is not the last one Treerow downTreerow = treeItems.get(myPosition + 1).getTreerow();