From 55ad1b571ba87f485a0643ba90f99eeede0ebe12 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=93scar=20Gonz=C3=A1lez=20Fern=C3=A1ndez?=
 <ogonzalez@igalia.com>
Date: Wed, 2 Feb 2011 20:14:50 +0100
Subject: [PATCH] Avoid repeating query

FEA: ItEr69S10CriteriaLoadRefinement
---
 .../web/resourceload/LoadPeriodGenerator.java        | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/navalplanner-webapp/src/main/java/org/navalplanner/web/resourceload/LoadPeriodGenerator.java b/navalplanner-webapp/src/main/java/org/navalplanner/web/resourceload/LoadPeriodGenerator.java
index 9e6a73a59..ddddeb5fd 100644
--- a/navalplanner-webapp/src/main/java/org/navalplanner/web/resourceload/LoadPeriodGenerator.java
+++ b/navalplanner-webapp/src/main/java/org/navalplanner/web/resourceload/LoadPeriodGenerator.java
@@ -91,19 +91,15 @@ abstract class LoadPeriodGenerator {
 
     public static LoadPeriodGeneratorFactory onCriterion(
             final Criterion criterion, final IResourceDAO resourcesDAO) {
+        final List<Resource> potentialResources = resourcesDAO
+                .findSatisfyingAllCriterionsAtSomePoint(Collections
+                        .singletonList(criterion));
         return new LoadPeriodGeneratorFactory() {
 
             @Override
             public LoadPeriodGenerator create(ResourceAllocation<?> allocation) {
                 return new LoadPeriodGeneratorOnCriterion(criterion,
-                        allocation, findResources(criterion, resourcesDAO));
-            }
-
-            private List<Resource> findResources(final Criterion criterion,
-                    final IResourceDAO resourcesDAO) {
-                return resourcesDAO
-                        .findSatisfyingAllCriterionsAtSomePoint(Collections
-                                .singletonList(criterion));
+                        allocation, potentialResources);
             }
         };
     }