From 6107e1b3bc99f6db3102d8de0f776d197c1749ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jacobo=20Aragunde=20P=C3=A9rez?= Date: Wed, 22 Dec 2010 16:22:48 +0100 Subject: [PATCH] Simplified the code in TaskPropertiesController merging two listeners into a single one. FEA: ItEr66OTS04XestionRecursosEstratexicosItEr65OTS07 --- .../taskedition/TaskPropertiesController.java | 28 ++++++------------- 1 file changed, 9 insertions(+), 19 deletions(-) diff --git a/navalplanner-webapp/src/main/java/org/navalplanner/web/planner/taskedition/TaskPropertiesController.java b/navalplanner-webapp/src/main/java/org/navalplanner/web/planner/taskedition/TaskPropertiesController.java index acbc93680..e773c8b5c 100644 --- a/navalplanner-webapp/src/main/java/org/navalplanner/web/planner/taskedition/TaskPropertiesController.java +++ b/navalplanner-webapp/src/main/java/org/navalplanner/web/planner/taskedition/TaskPropertiesController.java @@ -229,17 +229,6 @@ public class TaskPropertiesController extends GenericForwardComposer { startConstraintDate.setDisabled(disabled); lbResourceAllocationType.setDisabled(disabled); - lbResourceAllocationType.addEventListener(Events.ON_SELECT, - new EventListener() { - @Override - public void onEvent(Event event) throws Exception { - - editTaskController - .selectAssignmentTab(lbResourceAllocationType - .getSelectedIndex() + 1); - } - }); - if (context != null) { taskEditFormComposer.init(context.getRelativeTo(), context.getTask()); } @@ -404,14 +393,15 @@ public class TaskPropertiesController extends GenericForwardComposer { final ResourceAllocationTypeEnum oldState = getOldState(); ResourceAllocationTypeEnum newState = getSelectedValue(new ArrayList(se.getSelectedItems())); - if (thereIsTransition(newState)) { - if (isConsolidatedTask()) { - restoreOldState(); - editTaskController - .showNonPermitChangeResourceAllocationType(); - } else { - changeResourceAllocationType(oldState, newState); - } + if (thereIsTransition(newState)) { + if (isConsolidatedTask()) { + restoreOldState(); + editTaskController.showNonPermitChangeResourceAllocationType(); + } else { + changeResourceAllocationType(oldState, newState); + editTaskController.selectAssignmentTab(lbResourceAllocationType + .getSelectedIndex() + 1); + } } if (oldState == null) { setOldState(newState);