RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor

Browse source 
Extract method so the method has the same level of abstraction.

FEA: ItEr70S04BugFixing
This commit is contained in:
Óscar González Fernández 2011-02-15 16:29:10 +01:00
parent 1dba5fb5f7
commit 64c0e70642
1 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
navalplanner-webapp/src/main/java/org/navalplanner/web/orders/OrderModel.java
View file

@ -490,12 +490,9 @@ public class OrderModel extends IntegrationEntityModel implements IOrderModel {
private void dontPoseAsTransientObjectAnymore(OrderElement orderElement) {
dontPoseAsTransientObjectAnymore(orderElement.getTaskSourcesFromBottomToTop());
dontPoseAsTransientObjectAnymore(orderElement.getSchedulingDatasForVersionFromBottomToTop());
Set<DirectAdvanceAssignment> directAdvanceAssignments = orderElement.getDirectAdvanceAssignments();
for (DirectAdvanceAssignment directAdvanceAssignment : directAdvanceAssignments) {
directAdvanceAssignment.dontPoseAsTransientObjectAnymore();
dontPoseAsTransientObjectAnymore(directAdvanceAssignment
.getAdvanceMeasurements());
}
dontPoseAsTransientObjectAnymore(orderElement.getDirectAdvanceAssignments());
dontPoseAsTransientObjectAnymore(getAllMeasurements(orderElement.getDirectAdvanceAssignments()));
dontPoseAsTransientObjectAnymore(orderElement
.getIndirectAdvanceAssignments());
@ -503,12 +500,22 @@ public class OrderModel extends IntegrationEntityModel implements IOrderModel {
dontPoseAsTransientObjectAnymore(orderElement.getLabels());
dontPoseAsTransientObjectAnymore(orderElement.getTaskElements());
dontPoseAsTransientObjectAnymore(orderElement.getHoursGroups());
for(OrderElement child : orderElement.getAllChildren()) {
child.dontPoseAsTransientObjectAnymore();
dontPoseAsTransientObjectAnymore(child);
}
}
private List<AdvanceMeasurement> getAllMeasurements(
Collection<? extends DirectAdvanceAssignment> assignments) {
List<AdvanceMeasurement> result = new ArrayList<AdvanceMeasurement>();
for (DirectAdvanceAssignment each : assignments) {
result.addAll(each.getAdvanceMeasurements());
}
return result;
}
private void saveOnTransaction(boolean newOrderVersionNeeded) {
Order.checkConstraintOrderUniqueCode(order);
HoursGroup.checkConstraintHoursGroupUniqueCode(order);