From 66528ab3e3f84eaf54baebfb5ef6d85ef9071d89 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=93scar=20Gonz=C3=A1lez=20Fern=C3=A1ndez?= Date: Sun, 23 Aug 2009 13:37:36 +0200 Subject: [PATCH] ItEr23S03ContornaItEr22S03: Checking that the category throws IllegalArgumentException when receiving a not valid percentage --- .../java/org/zkoss/ganttz/data/resourceload/LoadLevel.java | 4 ++-- .../org/zkoss/ganttz/data/resourceload/LoadLevelTest.java | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/ganttzk/src/main/java/org/zkoss/ganttz/data/resourceload/LoadLevel.java b/ganttzk/src/main/java/org/zkoss/ganttz/data/resourceload/LoadLevel.java index 6073d3df6..ecd1a9b23 100644 --- a/ganttzk/src/main/java/org/zkoss/ganttz/data/resourceload/LoadLevel.java +++ b/ganttzk/src/main/java/org/zkoss/ganttz/data/resourceload/LoadLevel.java @@ -15,7 +15,7 @@ public class LoadLevel { SOME_LOAD { @Override public boolean contains(int percentage) { - return percentage < 100; + return percentage > 0 && percentage < 100; } }, FULL_LOAD { @@ -37,7 +37,7 @@ public class LoadLevel { if (category.contains(percentage)) return category; } - throw new RuntimeException("couldn't handle " + percentage); + throw new IllegalArgumentException("couldn't handle " + percentage); } } diff --git a/ganttzk/src/test/java/org/zkoss/ganttz/data/resourceload/LoadLevelTest.java b/ganttzk/src/test/java/org/zkoss/ganttz/data/resourceload/LoadLevelTest.java index 0c3bae9f1..d4e9b7a66 100644 --- a/ganttzk/src/test/java/org/zkoss/ganttz/data/resourceload/LoadLevelTest.java +++ b/ganttzk/src/test/java/org/zkoss/ganttz/data/resourceload/LoadLevelTest.java @@ -60,4 +60,9 @@ public class LoadLevelTest { thenTheCategoryIs(Category.OVERLOAD); } + @Test(expected = IllegalArgumentException.class) + public void theCategoryThrowsExceptionIfCantHandleThePercentage() { + Category.categoryFor(-1); + } + }