From 749de4e56950e87f04df4e0d5c50cffcb7ca9278 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jacobo=20Aragunde=20P=C3=A9rez?= <jaragunde@igalia.com>
Date: Tue, 27 Mar 2012 10:45:05 +0200
Subject: [PATCH] Bug #1387: Code refactor of the previous patches for this
 bug.

FEA: ItEr76S04BugFixing
---
 .../libreplan/business/orders/entities/OrderElement.java  | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/libreplan-business/src/main/java/org/libreplan/business/orders/entities/OrderElement.java b/libreplan-business/src/main/java/org/libreplan/business/orders/entities/OrderElement.java
index 496658d7e..0759ea346 100644
--- a/libreplan-business/src/main/java/org/libreplan/business/orders/entities/OrderElement.java
+++ b/libreplan-business/src/main/java/org/libreplan/business/orders/entities/OrderElement.java
@@ -290,7 +290,7 @@ public abstract class OrderElement extends IntegrationEntity implements
             SchedulingDataForVersion schedulingDataForVersion) {
         List<TaskSourceSynchronization> result = new ArrayList<TaskSourceSynchronization>();
         if (isSchedulingPoint()) {
-            if (itWasntSchedulingPoint()) {
+            if (!wasASchedulingPoint()) {
                 //this element was a container but now it's a scheduling point
                 //we have to remove the TaskSource which contains a TaskGroup instead of TaskElement
                 removeTaskSource(result);
@@ -329,12 +329,6 @@ public abstract class OrderElement extends IntegrationEntity implements
                 .getSchedulingStateType();
     }
 
-    private boolean itWasntSchedulingPoint() {
-        SchedulingDataForVersion currentVersionOnDB = getCurrentVersionOnDB();
-        return SchedulingState.Type.SCHEDULING_POINT != currentVersionOnDB
-                .getSchedulingStateType();
-    }
-
     private List<TaskSourceSynchronization> childrenSynchronizations() {
         List<TaskSourceSynchronization> childrenOfGroup = new ArrayList<TaskSourceSynchronization>();
         for (OrderElement orderElement : getSomewhatScheduledOrderElements()) {