RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Bug #1291] Fix NPE when a task with a dependency is removed

Browse source 
FEA: ItEr75S04BugFixing
This commit is contained in:
Manuel Rego Casasnovas 2011-12-14 13:07:26 +01:00
parent da745ed034
commit 760d4aaf15
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
libreplan-business/src/main/java/org/libreplan/business/planner/entities/TaskElement.java
View file

@ -485,7 +485,10 @@ public abstract class TaskElement extends BaseEntity {
private void detachIncomingDependencies() {
Set<TaskElement> tasksToNotify = new HashSet<TaskElement>();
for (Dependency dependency : dependenciesWithThisDestination) {
tasksToNotify.add(dependency.getOrigin());
TaskElement origin = dependency.getOrigin();
if (origin != null) {
tasksToNotify.add(origin);
}
}
for (TaskElement taskElement : tasksToNotify) {
taskElement.removeDependenciesWithDestination(this);
@ -495,7 +498,10 @@ public abstract class TaskElement extends BaseEntity {
private void detachOutcomingDependencies() {
Set<TaskElement> tasksToNotify = new HashSet<TaskElement>();
for (Dependency dependency : dependenciesWithThisOrigin) {
tasksToNotify.add(dependency.getDestination());
TaskElement destination = dependency.getDestination();
if (destination != null) {
tasksToNotify.add(destination);
}
}
for (TaskElement taskElement : tasksToNotify) {
taskElement.removeDependenciesWithOrigin(this);