From 767d2a87aa4b8abee7e4a56651f0946d46ebcacc Mon Sep 17 00:00:00 2001 From: Susana Montes Pedreira Date: Mon, 21 Nov 2011 09:26:51 +0100 Subject: [PATCH] it reduces the visibility of the constructor and uses the inherited method create [FEA] ItEr75S30SubcontractorIncommingCommunicationsLists --- .../externalcompanies/entities/CustomerComunication.java | 6 +++--- .../planner/entities/SubcontractorComunication.java | 6 +++--- .../planner/entities/SubcontractorComunicationValue.java | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libreplan-business/src/main/java/org/libreplan/business/externalcompanies/entities/CustomerComunication.java b/libreplan-business/src/main/java/org/libreplan/business/externalcompanies/entities/CustomerComunication.java index 030b52c3a..02b908f84 100644 --- a/libreplan-business/src/main/java/org/libreplan/business/externalcompanies/entities/CustomerComunication.java +++ b/libreplan-business/src/main/java/org/libreplan/business/externalcompanies/entities/CustomerComunication.java @@ -55,15 +55,15 @@ public class CustomerComunication extends BaseEntity{ } public static CustomerComunication create() { - return (CustomerComunication) create(new CustomerComunication()); + return create(new CustomerComunication()); } public static CustomerComunication createToday(Date deadline) { - return (CustomerComunication) create(new CustomerComunication(deadline)); + return create(new CustomerComunication(deadline)); } public static CustomerComunication createTodayNewProject(Date deadline) { - return (CustomerComunication) create(new CustomerComunication(deadline, + return create(new CustomerComunication(deadline, new Date(), ComunicationType.NEW_PROJECT)); } diff --git a/libreplan-business/src/main/java/org/libreplan/business/planner/entities/SubcontractorComunication.java b/libreplan-business/src/main/java/org/libreplan/business/planner/entities/SubcontractorComunication.java index 495b28228..36d971093 100644 --- a/libreplan-business/src/main/java/org/libreplan/business/planner/entities/SubcontractorComunication.java +++ b/libreplan-business/src/main/java/org/libreplan/business/planner/entities/SubcontractorComunication.java @@ -63,12 +63,12 @@ public class SubcontractorComunication extends BaseEntity { SubcontractedTaskData subcontractedTaskData, ComunicationType comunicationType, Date comunicationDate, Boolean reviewed) { - return new SubcontractorComunication(subcontractedTaskData, - comunicationType, comunicationDate, reviewed); + return create(new SubcontractorComunication(subcontractedTaskData, + comunicationType, comunicationDate, reviewed)); } public static SubcontractorComunication create() { - return new SubcontractorComunication(); + return create(new SubcontractorComunication()); } public void setSubcontractedTaskData(SubcontractedTaskData subcontractedTaskData) { diff --git a/libreplan-business/src/main/java/org/libreplan/business/planner/entities/SubcontractorComunicationValue.java b/libreplan-business/src/main/java/org/libreplan/business/planner/entities/SubcontractorComunicationValue.java index 6b5f88b80..0a10247ff 100644 --- a/libreplan-business/src/main/java/org/libreplan/business/planner/entities/SubcontractorComunicationValue.java +++ b/libreplan-business/src/main/java/org/libreplan/business/planner/entities/SubcontractorComunicationValue.java @@ -53,11 +53,11 @@ public class SubcontractorComunicationValue implements INewObject { return subcontractorComunicationValue; } - public SubcontractorComunicationValue() { + protected SubcontractorComunicationValue() { } - public SubcontractorComunicationValue(Date date, BigDecimal progress) { + private SubcontractorComunicationValue(Date date, BigDecimal progress) { this.setDate(date); this.setProgress(progress); }