RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Reimplemented getHoursAdvancePercentage() to avoid calling OrderElementDAO.getHoursAdvancePercentage().

Browse source 
The DAO method makes recursive calls over all the children of the order.
The reimplementation uses the pre-calculated data on the TaskElement to
prevent recursive calls.

FEA: ItEr61S03RFPerformanceCompanyView
This commit is contained in:
Jacobo Aragunde Pérez 2010-10-07 13:09:25 +02:00
parent 222c966f20
commit 79425a183f
1 changed files with 14 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
navalplanner-webapp/src/main/java/org/navalplanner/web/planner/TaskElementAdapter.java
View file

@ -337,11 +337,21 @@ public class TaskElementAdapter implements ITaskElementAdapter {
@Override
public BigDecimal getHoursAdvancePercentage() {
OrderElement orderElement = taskElement.getOrderElement();
if (orderElement != null) {
return orderElementDAO.getHoursAdvancePercentage(orderElement);
} else {
return new BigDecimal(0);
if (orderElement == null) {
return BigDecimal.ZERO;
}
Integer totalChargedHours = orderElement.getSumChargedHours() != null ? orderElement
.getSumChargedHours().getTotalChargedHours() : new Integer(0);
BigDecimal assignedHours = new BigDecimal(totalChargedHours).setScale(2);
BigDecimal estimatedHours = new BigDecimal(taskElement.getSumOfHoursAllocated())
.setScale(2);
if (estimatedHours.compareTo(BigDecimal.ZERO) <= 0) {
return BigDecimal.ZERO;
}
return assignedHours.divide(estimatedHours, RoundingMode.DOWN);
}
@Override