From 878e067683780fdeb93882a5c8b1ce62512b67cd Mon Sep 17 00:00:00 2001
From: Vova Perebykivskiy <vova@libreplan-enterprise.com>
Date: Tue, 10 Nov 2015 11:56:42 +0200
Subject: [PATCH] Add possibility to disable E-mail sending with Maven compiler
 option.

---
 HACKING.rst                                   |  3 ++
 .../business/common/Configuration.java        | 42 +++++++++++++------
 .../libreplan-business-spring-config.xml      |  3 ++
 .../org/libreplan/importers/SendEmail.java    | 12 +++---
 pom.xml                                       |  1 +
 5 files changed, 42 insertions(+), 19 deletions(-)

diff --git a/HACKING.rst b/HACKING.rst
index b6aec7557..4e2d7efdf 100644
--- a/HACKING.rst
+++ b/HACKING.rst
@@ -506,6 +506,9 @@ example:
 
     mvn -Ddefault.passwordsControl=false -Ddefault.exampleUsersDisabled=false clean install
 
+* Set *default.emailSendingDisabled* to true::
+
+    mvn -Ddefault.emailSendingDisabled=true clean install
 
 Tests
 -----
diff --git a/libreplan-business/src/main/java/org/libreplan/business/common/Configuration.java b/libreplan-business/src/main/java/org/libreplan/business/common/Configuration.java
index 80c084ffd..680de01af 100644
--- a/libreplan-business/src/main/java/org/libreplan/business/common/Configuration.java
+++ b/libreplan-business/src/main/java/org/libreplan/business/common/Configuration.java
@@ -26,16 +26,19 @@ import org.apache.commons.lang.BooleanUtils;
 /**
  * This is a singleton that contains the compilation options passed from Maven.
  *
- * Currently we have two options:
+ * Currently we have three options:
  * <ul>
  * <li>Enable/Disable the warning changing default password</li>
  * <li>Enable/Disable default users (such as wsreader, wswriter,
  * wssubcontracting, manager, hresources, outsourcing and reports)</li>
+ * <li>Enable/Disable E-mail sending functionality</li>
  * </ul>
  *
  * @author Susana Montes Pedreira <smontes@wirelessgalicia.com>
  * @author Manuel Rego Casasnovas <rego@igalia.com>
+ * @author Vova Perebykivskiy <vova@libreplan-enterprise.com>
  */
+
 public class Configuration {
 
     private static final Configuration singleton = new Configuration();
@@ -44,6 +47,8 @@ public class Configuration {
 
     private Boolean exampleUsersDisabled;
 
+    private Boolean emailSendingDisabled;
+
     private Configuration() {
     }
 
@@ -59,22 +64,13 @@ public class Configuration {
         return singleton.getDefaultPasswordsControl() != null ? singleton
                 .getDefaultPasswordsControl() : true;
     }
-
+    public Boolean getDefaultPasswordsControl() {
+        return defaultPasswordsControl;
+    }
     public void setDefaultPasswordsControl(Boolean defaultPasswordsControl) {
         this.defaultPasswordsControl = defaultPasswordsControl;
     }
 
-    public Boolean getDefaultPasswordsControl() {
-        return defaultPasswordsControl;
-    }
-
-    public void setExampleUsersDisabled(Boolean exampleUsersDisabled) {
-        this.exampleUsersDisabled = exampleUsersDisabled;
-    }
-
-    public Boolean getExampleUsersDisabled() {
-        return exampleUsersDisabled;
-    }
 
     /**
      * Returns the value of example users disabled compilation option
@@ -82,5 +78,25 @@ public class Configuration {
     public static boolean isExampleUsersDisabled() {
         return BooleanUtils.isNotFalse(singleton.getExampleUsersDisabled());
     }
+    public Boolean getExampleUsersDisabled() {
+        return exampleUsersDisabled;
+    }
+    public void setExampleUsersDisabled(Boolean exampleUsersDisabled) {
+        this.exampleUsersDisabled = exampleUsersDisabled;
+    }
+
+
+    /**
+     * Returns the value of E-mail sending disabled compilation option
+     */
+    public static boolean isEmailSendingDisabled(){
+        return BooleanUtils.isNotFalse(singleton.getEmailSendingDisabled());
+    }
+    public Boolean getEmailSendingDisabled(){
+        return emailSendingDisabled;
+    }
+    public void setEmailSendingDisabled(Boolean emailSendingDisabled){
+        this.emailSendingDisabled = emailSendingDisabled;
+    }
 
 }
diff --git a/libreplan-business/src/main/resources/libreplan-business-spring-config.xml b/libreplan-business/src/main/resources/libreplan-business-spring-config.xml
index 6bc5398f3..8323c6d05 100644
--- a/libreplan-business/src/main/resources/libreplan-business-spring-config.xml
+++ b/libreplan-business/src/main/resources/libreplan-business-spring-config.xml
@@ -146,6 +146,9 @@
         <property name="exampleUsersDisabled">
             <value>${default.exampleUsersDisabled}</value>
         </property>
+        <property name="emailSendingDisabled">
+            <value>${default.emailSendingDisabled}</value>
+        </property>
     </bean>
 
     <bean id="scenarioManager"
diff --git a/libreplan-webapp/src/main/java/org/libreplan/importers/SendEmail.java b/libreplan-webapp/src/main/java/org/libreplan/importers/SendEmail.java
index 9b651ae0a..e8fdc57c2 100644
--- a/libreplan-webapp/src/main/java/org/libreplan/importers/SendEmail.java
+++ b/libreplan-webapp/src/main/java/org/libreplan/importers/SendEmail.java
@@ -19,6 +19,7 @@
 
 package org.libreplan.importers;
 
+import org.libreplan.business.common.Configuration;
 import org.libreplan.business.common.daos.IConnectorDAO;
 import org.libreplan.business.common.entities.Connector;
 import org.libreplan.business.common.entities.ConnectorProperty;
@@ -80,12 +81,11 @@ public class SendEmail implements ISendEmail {
 
     @Override
     public void sendEmail() {
-
-        notifications = emailNotificationModel.getAll();
-
-        for (int i = 0; i < notifications.size(); i++) composeMessageForUser(notifications.get(i));
-
-        deleteAllNotificationsAfterSending();
+        if ( !Configuration.isEmailSendingDisabled() ){
+            notifications = emailNotificationModel.getAll();
+            for (int i = 0; i < notifications.size(); i++) composeMessageForUser(notifications.get(i));
+            deleteAllNotificationsAfterSending();
+        }
     }
 
     private void composeMessageForUser(EmailNotification notification){
diff --git a/pom.xml b/pom.xml
index 91890d77e..14a681dd9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -37,6 +37,7 @@
 
         <default.passwordsControl>true</default.passwordsControl>
         <default.exampleUsersDisabled>true</default.exampleUsersDisabled>
+        <default.emailSendingDisabled>false</default.emailSendingDisabled>
 
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     </properties>