From 88e084fde1e40fdb25f84a7494e4e725b03fdbf9 Mon Sep 17 00:00:00 2001 From: Nacho Barrientos Date: Mon, 14 Nov 2011 17:42:53 +0100 Subject: [PATCH] Fix coding style. Add space in for/if statements. FEA: ItEr75S27PerProjectDashboard --- .../org/libreplan/business/planner/entities/Task.java | 4 ++-- .../libreplan/business/planner/entities/TaskGroup.java | 10 +++++----- .../visitors/AccumulateTasksDeadlineStatusVisitor.java | 2 +- .../visitors/AccumulateTasksStatusVisitor.java | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/libreplan-business/src/main/java/org/libreplan/business/planner/entities/Task.java b/libreplan-business/src/main/java/org/libreplan/business/planner/entities/Task.java index d48652830..655f26a3e 100644 --- a/libreplan-business/src/main/java/org/libreplan/business/planner/entities/Task.java +++ b/libreplan-business/src/main/java/org/libreplan/business/planner/entities/Task.java @@ -1140,7 +1140,7 @@ public class Task extends TaskElement implements ITaskPositionConstrained { return false; } Set dependencies = this.getDependenciesWithThisDestination(); - for(Dependency dependency: dependencies) { + for (Dependency dependency: dependencies) { Type dependencyType = dependency.getType(); if (dependencyType.equals(Type.END_START)) { if (!dependency.getOrigin().isFinished()) { @@ -1161,7 +1161,7 @@ public class Task extends TaskElement implements ITaskPositionConstrained { return false; } Set dependencies = this.getDependenciesWithThisDestination(); - for(Dependency dependency: dependencies) { + for (Dependency dependency: dependencies) { Type dependencyType = dependency.getType(); if (dependencyType.equals(Type.END_START)) { if (!dependency.getOrigin().isFinished()) { diff --git a/libreplan-business/src/main/java/org/libreplan/business/planner/entities/TaskGroup.java b/libreplan-business/src/main/java/org/libreplan/business/planner/entities/TaskGroup.java index a7b3eb7f8..480aa1523 100644 --- a/libreplan-business/src/main/java/org/libreplan/business/planner/entities/TaskGroup.java +++ b/libreplan-business/src/main/java/org/libreplan/business/planner/entities/TaskGroup.java @@ -310,7 +310,7 @@ public class TaskGroup extends TaskElement { @Override public EffortDuration getTheoreticalCompletedTimeUntilDate(Date date) { EffortDuration sum = EffortDuration.zero(); - for(TaskElement each: taskElements) { + for (TaskElement each: taskElements) { sum = EffortDuration.sum(sum, each.getTheoreticalCompletedTimeUntilDate(date)); } return sum; @@ -318,8 +318,8 @@ public class TaskGroup extends TaskElement { @Override public boolean isFinished() { - for(TaskElement each: taskElements) { - if(!each.isFinished()) + for (TaskElement each: taskElements) { + if (!each.isFinished()) return false; } return true; @@ -327,8 +327,8 @@ public class TaskGroup extends TaskElement { @Override public boolean isInProgress() { - for(TaskElement each: taskElements) { - if(each.isInProgress()) + for (TaskElement each: taskElements) { + if (each.isInProgress()) return true; } return false; diff --git a/libreplan-business/src/main/java/org/libreplan/business/planner/entities/visitors/AccumulateTasksDeadlineStatusVisitor.java b/libreplan-business/src/main/java/org/libreplan/business/planner/entities/visitors/AccumulateTasksDeadlineStatusVisitor.java index 22a0a06ec..20fee15a0 100644 --- a/libreplan-business/src/main/java/org/libreplan/business/planner/entities/visitors/AccumulateTasksDeadlineStatusVisitor.java +++ b/libreplan-business/src/main/java/org/libreplan/business/planner/entities/visitors/AccumulateTasksDeadlineStatusVisitor.java @@ -53,7 +53,7 @@ public class AccumulateTasksDeadlineStatusVisitor extends TaskElementVisitor { } public void visit(TaskGroup taskGroup) { - for(TaskElement each: taskGroup.getAllChildren()) { + for (TaskElement each: taskGroup.getAllChildren()) { each.acceptVisitor(this); } } diff --git a/libreplan-business/src/main/java/org/libreplan/business/planner/entities/visitors/AccumulateTasksStatusVisitor.java b/libreplan-business/src/main/java/org/libreplan/business/planner/entities/visitors/AccumulateTasksStatusVisitor.java index dffa8ec50..2297af1bb 100644 --- a/libreplan-business/src/main/java/org/libreplan/business/planner/entities/visitors/AccumulateTasksStatusVisitor.java +++ b/libreplan-business/src/main/java/org/libreplan/business/planner/entities/visitors/AccumulateTasksStatusVisitor.java @@ -40,7 +40,7 @@ public class AccumulateTasksStatusVisitor extends TaskElementVisitor { public AccumulateTasksStatusVisitor() { this.taskStatusData = new EnumMap(TaskStatusEnum.class); - for(TaskStatusEnum status: TaskStatusEnum.values()) { + for (TaskStatusEnum status: TaskStatusEnum.values()) { this.taskStatusData.put(status, new Integer(0)); } } @@ -56,7 +56,7 @@ public class AccumulateTasksStatusVisitor extends TaskElementVisitor { } public void visit(TaskGroup taskGroup) { - for(TaskElement each: taskGroup.getAllChildren()) { + for (TaskElement each: taskGroup.getAllChildren()) { each.acceptVisitor(this); } }