RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Bug #1080] Fixed issue with Montecarlo method when critical path has more than 10 tasks.

Browse source 
* Force render for tasks that are in pages not been active.
* Moved out of long operation percentages validation.
* Setting properly active page when some percentage is not valid.

FEA: ItEr74S04BugFixing
This commit is contained in:
Manuel Rego Casasnovas 2011-05-25 08:41:34 +02:00
parent 35adfb3222
commit 939aa1f14a
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
navalplanner-webapp/src/main/java/org/navalplanner/web/montecarlo/MonteCarloController.java
View file

@ -114,6 +114,7 @@ public class MonteCarloController extends GenericForwardComposer {
@Override
public void onEvent(Event event) throws Exception {
validateRowsPercentages();
IBackGroundOperation<IDesktopUpdate> operation = new IBackGroundOperation<IDesktopUpdate>() {
@Override
@ -130,7 +131,6 @@ public class MonteCarloController extends GenericForwardComposer {
try {
updatesEmitter.doUpdate(disableButton(true));
int iterations = getIterations();
validateRowsPercentages();
final Map<LocalDate, BigDecimal> monteCarloData = monteCarloModel
.calculateMonteCarlo(getSelectedCriticalPath(),
iterations,
@ -169,6 +169,9 @@ public class MonteCarloController extends GenericForwardComposer {
private void validateRowsPercentages() {
Intbox intbox;
int page = 0;
int counter = 0;
Rows rows = gridCriticalPathTasks.getRows();
for (Object each : rows.getChildren()) {
Row row = (Row) each;
@ -184,9 +187,15 @@ public class MonteCarloController extends GenericForwardComposer {
sum += intbox.getValue();
if (sum != 100) {
gridCriticalPathTasks.setActivePage(page);
throw new WrongValueException(row,
_("Percentages should sum 100"));
}
counter++;
if (counter % gridCriticalPathTasks.getPageSize() == 0) {
page++;
}
}
}
@ -275,6 +284,7 @@ public class MonteCarloController extends GenericForwardComposer {
}
if (gridCriticalPathTasks.getRowRenderer() == null) {
gridCriticalPathTasks.setRowRenderer(gridCriticalPathTasksRender);
gridCriticalPathTasks.renderAll();
}
}