RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Performance improvement

Browse source 
When calculating the load ratio of each resource, a new transaction is
being created for each one. Now one transaction is reused for
everyone, which gives a good performance boost when loading the
`Advanced search`.
This commit is contained in:
Oscar Gonzalez Fernandez 2014-04-20 18:07:47 +02:00
parent 18b187fad8
commit a109c50984
2 changed files with 19 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
libreplan-webapp/src/main/java/org/libreplan/web/resources/search/AllocationSelectorController.java
View file

@ -23,6 +23,7 @@ package org.libreplan.web.resources.search;
import java.util.List;
import org.libreplan.business.common.IAdHocTransactionService;
import org.libreplan.business.resources.daos.IResourceLoadRatiosCalculator;
import org.libreplan.business.resources.daos.IResourcesSearcher;
import org.libreplan.business.resources.entities.Criterion;
@ -42,6 +43,9 @@ public abstract class AllocationSelectorController extends
// injected by name
protected IResourcesSearcher resourcesSearcher;
// injected by name
protected IAdHocTransactionService adHocTransactionService;
// injected by name
protected IResourceLoadRatiosCalculator resourceLoadRatiosCalculator;

18
libreplan-webapp/src/main/java/org/libreplan/web/resources/search/NewAllocationSelectorController.java
View file

@ -38,6 +38,7 @@ import java.util.Set;
import org.apache.commons.lang.Validate;
import org.joda.time.LocalDate;
import org.libreplan.business.common.IOnTransaction;
import org.libreplan.business.resources.daos.IResourceLoadRatiosCalculator.ILoadRatiosDataType;
import org.libreplan.business.resources.daos.IResourcesSearcher.IResourcesQuery;
import org.libreplan.business.resources.entities.Criterion;
@ -394,14 +395,25 @@ public class NewAllocationSelectorController extends
public void clearAll() {
}
public void open(LocalDate start, LocalDate end) {
public void open(final LocalDate start, final LocalDate end) {
setStartFilteringDate(start);
setEndFilteringDate(end);
refreshListBoxResources();
clearSelection(listBoxResources);
clearSelection(criterionsTree);
criterionsTree.setModel(getCriterions());
adHocTransactionService
.runOnReadOnlyTransaction(new IOnTransaction<Void>() {
@Override
public Void execute() {
refreshListBoxResources();
criterionsTree.setModel(getCriterions());
return null;
}
});
doInitialSelection();
}