diff --git a/navalplanner-webapp/src/main/java/org/navalplanner/web/orders/OrderCRUDController.java b/navalplanner-webapp/src/main/java/org/navalplanner/web/orders/OrderCRUDController.java index 420e15ac0..71bbe1d08 100644 --- a/navalplanner-webapp/src/main/java/org/navalplanner/web/orders/OrderCRUDController.java +++ b/navalplanner-webapp/src/main/java/org/navalplanner/web/orders/OrderCRUDController.java @@ -64,9 +64,7 @@ public class OrderCRUDController extends GenericForwardComposer { private Component messagesContainer; - private Component editWindow; - - private Component createWindow; + private Window editWindow; private Component listWindow; @@ -80,8 +78,7 @@ public class OrderCRUDController extends GenericForwardComposer { private OnlyOneVisible getVisibility() { if (cachedOnlyOneVisible == null) { - cachedOnlyOneVisible = new OnlyOneVisible(listWindow, editWindow, - createWindow); + cachedOnlyOneVisible = new OnlyOneVisible(listWindow, editWindow); } return cachedOnlyOneVisible; } @@ -195,29 +192,24 @@ public class OrderCRUDController extends GenericForwardComposer { public void goToEditForm(Order order) { orderModel.prepareEditFor(order); - clearOrderElementTreeController(editWindow); - selectDefaultTab(editWindow); + showEditWindow(_("Edit order")); + } + + private void showEditWindow(String title) { + clearEditWindow(); + editWindow.setTitle(title); getVisibility().showOnly(editWindow); Util.reloadBindings(editWindow); } - private void selectDefaultTab(Component comp) { - Tab tabGeneralData = (Tab) comp.getFellowIfAny("tabGeneralData"); - tabGeneralData.setSelected(true); - } - - private void clearOrderElementTreeController(Component comp) { - OrderElementTreeController controller = (OrderElementTreeController) comp - .getVariable("orderElementTreeController", true); + private void clearEditWindow() { + OrderElementTreeController controller = (OrderElementTreeController) editWindow.getVariable("orderElementTreeController", true); controller.clear(); } public void goToCreateForm() { orderModel.prepareForCreate(); - clearOrderElementTreeController(createWindow); - selectDefaultTab(createWindow); - getVisibility().showOnly(createWindow); - Util.reloadBindings(createWindow); + showEditWindow(_("Create order")); } @Override @@ -230,11 +222,8 @@ public class OrderCRUDController extends GenericForwardComposer { OrderElementController orderElementController = new OrderElementController(); orderElementController.doAfterCompose(comp .getFellow("editOrderElement")); - setupOrderElementTreeController(comp, "editWindow", orderElementController); - setupOrderElementTreeController(comp, "createWindow", - orderElementController); } private void setupOrderElementTreeController(Component comp, String window, diff --git a/navalplanner-webapp/src/main/java/org/navalplanner/web/orders/OrderElementTreeController.java b/navalplanner-webapp/src/main/java/org/navalplanner/web/orders/OrderElementTreeController.java index 19bc892e2..7a7707f12 100644 --- a/navalplanner-webapp/src/main/java/org/navalplanner/web/orders/OrderElementTreeController.java +++ b/navalplanner-webapp/src/main/java/org/navalplanner/web/orders/OrderElementTreeController.java @@ -49,6 +49,7 @@ import org.zkoss.zul.Datebox; import org.zkoss.zul.Intbox; import org.zkoss.zul.Label; import org.zkoss.zul.RendererCtrl; +import org.zkoss.zul.Tab; import org.zkoss.zul.Textbox; import org.zkoss.zul.Tree; import org.zkoss.zul.TreeModel; @@ -726,9 +727,17 @@ public class OrderElementTreeController extends GenericForwardComposer { * {@link IPredicate} */ public void clear() { + selectDefaultTab(); cbFilterType.setSelectedIndex(0); bdFilter.clear(); predicate = null; } + Tab tabGeneralData; + + private void selectDefaultTab() { + tabGeneralData.setSelected(true); + } + + } diff --git a/navalplanner-webapp/src/main/webapp/orders/_edition.zul b/navalplanner-webapp/src/main/webapp/orders/_edition.zul index 4756e16d2..b7d56bb16 100644 --- a/navalplanner-webapp/src/main/webapp/orders/_edition.zul +++ b/navalplanner-webapp/src/main/webapp/orders/_edition.zul @@ -19,7 +19,7 @@ --> - + @@ -76,8 +76,6 @@ - - - +