RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ItEr33S08ValidacionEProbasFuncionaisItEr32S09: Removing not necessary ifs

Browse source
This commit is contained in:
Óscar González Fernández 2009-11-03 18:50:03 +01:00
parent 1d00f976ee
commit a2eac4d52a
2 changed files with 0 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
navalplanner-webapp/src/main/java/org/navalplanner/web/common/InvalidInputsChecker.java
View file

@ -37,9 +37,6 @@ public class InvalidInputsChecker {
}
List<Component> children = component.getChildren();
for (Component child : children) {
if (isInvalid(child)) {
return true;
}
if (thereAreInvalidInputsOn(child)) {
return true;
}

22
navalplanner-webapp/src/main/java/org/navalplanner/web/orders/DetailsOrderElementController.java
View file

@ -259,9 +259,6 @@ public class DetailsOrderElementController extends
Listitem emptyListitem = new Listitem();
emptyListitem.setParent(criterionListbox);
// Get the Criterion of the current type in the HoursGroup
final Criterion criterionHoursGroup = null;
// For each possible Criterion of the current type
for (Criterion criterion : orderElementModel
.getCriterionsFor(criterionType)) {
@ -270,14 +267,6 @@ public class DetailsOrderElementController extends
listitem.setValue(criterion);
listitem.setLabel(criterion.getName());
listitem.setParent(criterionListbox);
// Check if it matches with the HoursGroup criterion
if ((criterionHoursGroup != null)
&& (criterionHoursGroup.getName()
.equals(criterion.getName()))) {
// Mark as selected
criterionListbox.setSelectedItem(listitem);
}
}
cellCriterion.appendChild(criterionListbox);
@ -395,9 +384,6 @@ public class DetailsOrderElementController extends
Listitem emptyListitem = new Listitem();
emptyListitem.setParent(criterionListbox);
// Get the Criterion of the current type in the HoursGroup
final Criterion criterionHoursGroup = null;
// For each possible Criterion of the current type
for (Criterion criterion : orderElementModel
.getCriterionsFor(criterionType)) {
@ -406,14 +392,6 @@ public class DetailsOrderElementController extends
listitem.setValue(criterion);
listitem.setLabel(criterion.getName());
listitem.setParent(criterionListbox);
// Check if it matches with the HoursGroup criterion
if ((criterionHoursGroup != null)
&& (criterionHoursGroup.getName()
.equals(criterion.getName()))) {
// Mark as selected
criterionListbox.setSelectedItem(listitem);
}
}
// Add operation for Criterion selection