From b2fa8ba9465b7fd45abc1967de182a0f4f0a69cd Mon Sep 17 00:00:00 2001
From: Susana Montes Pedreira <smpedreira@gmail.com>
Date: Sun, 3 Jan 2010 20:17:43 +0100
Subject: [PATCH]  ItEr41S05ValidacionEProbasFuncionaisItEr40S05 : more optimal
 filter in WorkReport list.

---
 .../web/workreports/WorkReportModel.java            | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/navalplanner-webapp/src/main/java/org/navalplanner/web/workreports/WorkReportModel.java b/navalplanner-webapp/src/main/java/org/navalplanner/web/workreports/WorkReportModel.java
index 14dafb8bf..98c91e2ab 100644
--- a/navalplanner-webapp/src/main/java/org/navalplanner/web/workreports/WorkReportModel.java
+++ b/navalplanner-webapp/src/main/java/org/navalplanner/web/workreports/WorkReportModel.java
@@ -89,6 +89,8 @@ public class WorkReportModel implements IWorkReportModel {
 
     private static final Map<LabelType, List<Label>> mapLabelTypes = new HashMap<LabelType, List<Label>>();
 
+    private List<WorkReportDTO> listWorkReportDTOs = new ArrayList<WorkReportDTO>();
+
     @Override
     public WorkReport getWorkReport() {
         return workReport;
@@ -242,20 +244,19 @@ public class WorkReportModel implements IWorkReportModel {
     @Transactional(readOnly = true)
     public List<WorkReportDTO> getWorkReportDTOs() {
         // load the work reports DTOs
-        List<WorkReport> listWorkReports = getAllWorkReports();
-        List<WorkReportDTO> resultDTOs = new ArrayList<WorkReportDTO>();
-        for (WorkReport workReport : listWorkReports) {
+        listWorkReportDTOs.clear();
+        for (WorkReport workReport : getAllWorkReports()) {
             WorkReportDTO workReportDTO = new WorkReportDTO(workReport);
-            resultDTOs.add(workReportDTO);
+            listWorkReportDTOs.add(workReportDTO);
         }
-        return resultDTOs;
+        return listWorkReportDTOs;
     }
 
     @Override
     @Transactional(readOnly = true)
     public List<WorkReportDTO> getFilterWorkReportDTOs(IPredicate predicate) {
         List<WorkReportDTO> resultDTOs = new ArrayList<WorkReportDTO>();
-        for (WorkReportDTO workReportDTO : getWorkReportDTOs()) {
+        for (WorkReportDTO workReportDTO : listWorkReportDTOs) {
             if (predicate.accepts(workReportDTO)) {
                 resultDTOs.add(workReportDTO);
             }