RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Bug #1081] validate and action stop if something fails while saving data

Browse source 
in progress type view.

FEA: ItEr74S04BugFixing
This commit is contained in:
Susana Montes Pedreira 2011-06-01 13:49:19 +02:00
parent c1e30ed2e7
commit b9b11e8cb6
2 changed files with 30 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
navalplanner-webapp/src/main/java/org/navalplanner/web/advance/AdvanceTypeCRUDController.java
View file

@ -48,6 +48,8 @@ import org.zkoss.zul.Label;
import org.zkoss.zul.Messagebox;
import org.zkoss.zul.Row;
import org.zkoss.zul.RowRenderer;
import org.zkoss.zul.Textbox;
import org.zkoss.zul.impl.InputElement;
/**
* Controller for CRUD actions over a {@link AdvanceType}
@ -165,14 +167,34 @@ public class AdvanceTypeCRUDController extends GenericForwardComposer {
}
private boolean save() {
try {
advanceTypeModel.save();
messagesForUser.showMessage(Level.INFO, _("Progress type saved"));
return true;
} catch (ValidationException e) {
messagesForUser.showInvalidValues(e);
return false;
if (isAllValid()) {
try {
advanceTypeModel.save();
messagesForUser.showMessage(Level.INFO,
_("Progress type saved"));
return true;
} catch (ValidationException e) {
messagesForUser.showInvalidValues(e);
return false;
}
}
return false;
}
private boolean isAllValid() {
Component window = this.getCurrentWindow();
Textbox unitName = (Textbox) window.getFellowIfAny("unitName");
InputElement defaultMaxValue = (InputElement) window
.getFellowIfAny("defaultMaxValue");
InputElement precision = (InputElement) window
.getFellowIfAny("precision");
unitName.setFocus(true);
return (isValid(unitName) && isValid(precision) && isValid(defaultMaxValue));
}
private boolean isValid(InputElement inputtext) {
inputtext.setFocus(true);
return inputtext.isValid();
}
public void confirmRemove(AdvanceType advanceType) {

2
navalplanner-webapp/src/main/webapp/advance/_editAdvanceTypes.zul
View file

@ -35,7 +35,7 @@
<rows>
<row>
<label value="${i18n:_('Unit name')}" />
<textbox value="@{controller.advanceType.unitName}" constraint="@{controller.distinctNames}" width="300px"
<textbox id="unitName" value="@{controller.advanceType.unitName}" constraint="@{controller.distinctNames}" width="300px"
disabled="@{controller.immutable}" />
</row>
<row>