From bc84bd77296c6ac79806ef968f826b8afddcddaa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=93scar=20Gonz=C3=A1lez=20Fern=C3=A1ndez?=
 <ogonzalez@igalia.com>
Date: Tue, 5 Oct 2010 21:36:55 +0200
Subject: [PATCH] Use Collections methods max and min to retrieve the smallest
 and biggest value

FEA: ItEr61S08TimeUnitConfigurablePlanning
---
 .../org/zkoss/ganttz/data/TaskContainer.java  | 32 ++-----------------
 1 file changed, 3 insertions(+), 29 deletions(-)

diff --git a/ganttzk/src/main/java/org/zkoss/ganttz/data/TaskContainer.java b/ganttzk/src/main/java/org/zkoss/ganttz/data/TaskContainer.java
index e88f0b907..a48389856 100644
--- a/ganttzk/src/main/java/org/zkoss/ganttz/data/TaskContainer.java
+++ b/ganttzk/src/main/java/org/zkoss/ganttz/data/TaskContainer.java
@@ -22,7 +22,7 @@ package org.zkoss.ganttz.data;
 
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.Comparator;
+import java.util.Collections;
 import java.util.Date;
 import java.util.List;
 
@@ -57,40 +57,14 @@ public class TaskContainer extends Task {
         return result;
     }
 
-    private static <T> T getSmallest(Collection<T> elements,
-            Comparator<T> comparator) {
-        List<T> withoutNulls = removeNulls(elements);
-        if (withoutNulls.isEmpty()) {
-            throw new IllegalArgumentException("at least one required");
-        }
-        T result = null;
-        for (T element : withoutNulls) {
-            result = result == null ? element : (comparator.compare(result,
-                    element) < 0 ? result : element);
-        }
-        return result;
-    }
-
     private static <T extends Comparable<? super T>> T getSmallest(
             Collection<T> elements) {
-        return getSmallest(elements, new Comparator<T>() {
-
-            @Override
-            public int compare(T o1, T o2) {
-                return o1.compareTo(o2);
-            }
-        });
+        return Collections.min(removeNulls(elements));
     }
 
     private static <T extends Comparable<? super T>> T getBiggest(
             Collection<T> elements) {
-        return getSmallest(elements, new Comparator<T>() {
-
-            @Override
-            public int compare(T o1, T o2) {
-                return o2.compareTo(o1);
-            }
-        });
+        return Collections.max(removeNulls(elements));
     }
 
     private List<Task> tasks = new ArrayList<Task>();