RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Bug #1119] DataIntegrityViolationException saving a new Process

Browse source 
FEA: ItEr75S04BugFixing
This commit is contained in:
Cristina Alvarino 2011-08-02 14:31:34 +02:00 • committed by Manuel Rego Casasnovas
parent 935344eade
commit ca7e470c18
3 changed files with 74 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
navalplanner-business/src/main/java/org/navalplanner/business/advance/daos/AdvanceTypeDAO.java
View file

@ -24,13 +24,17 @@ package org.navalplanner.business.advance.daos;
import java.util.Collection;
import java.util.List;
import org.hibernate.Criteria;
import org.hibernate.criterion.MatchMode;
import org.hibernate.criterion.Restrictions;
import org.navalplanner.business.advance.entities.AdvanceAssignment;
import org.navalplanner.business.advance.entities.AdvanceType;
import org.navalplanner.business.common.daos.GenericDAOHibernate;
import org.navalplanner.business.common.exceptions.InstanceNotFoundException;
import org.springframework.beans.factory.config.BeanDefinition;
import org.springframework.context.annotation.Scope;
import org.springframework.stereotype.Repository;
import org.springframework.transaction.annotation.Propagation;
import org.springframework.transaction.annotation.Transactional;
/**
@ -70,4 +74,37 @@ public class AdvanceTypeDAO extends GenericDAOHibernate<AdvanceType, Long>
Restrictions.eq("advanceType", advanceType)).list().isEmpty();
}
@Override
@Transactional(readOnly=true)
public AdvanceType findByNameCaseInsensitive(String name)
throws InstanceNotFoundException {
Criteria c = getSession().createCriteria(AdvanceType.class);
c.add(Restrictions.ilike("unitName", name, MatchMode.EXACT));
AdvanceType result = (AdvanceType) c.uniqueResult();
if (result == null) {
throw new InstanceNotFoundException(name,
getEntityClass().getName());
}
return result;
}
@Override
@Transactional(readOnly = true, propagation = Propagation.REQUIRES_NEW)
public boolean existsByNameInAnotherTransaction(String name) {
try {
findByNameCaseInsensitive(name);
} catch (InstanceNotFoundException e) {
return false;
}
return true;
}
@Override
@Transactional(readOnly = true, propagation = Propagation.REQUIRES_NEW)
public AdvanceType findUniqueByNameInAnotherTransaction(String name)
throws InstanceNotFoundException {
return findByNameCaseInsensitive(name);
}
}

9
navalplanner-business/src/main/java/org/navalplanner/business/advance/daos/IAdvanceTypeDAO.java
View file

@ -26,6 +26,7 @@ import java.util.List;
import org.navalplanner.business.advance.entities.AdvanceType;
import org.navalplanner.business.common.daos.IGenericDAO;
import org.navalplanner.business.common.exceptions.InstanceNotFoundException;
/**
* Contract for {@link AdvanceTypeDao}
@ -43,4 +44,12 @@ public interface IAdvanceTypeDAO extends IGenericDAO<AdvanceType, Long>{
public boolean isAlreadyInUse(AdvanceType advanceType);
AdvanceType findUniqueByNameInAnotherTransaction(String name)
throws InstanceNotFoundException;
boolean existsByNameInAnotherTransaction(String name);
AdvanceType findByNameCaseInsensitive(String name)
throws InstanceNotFoundException;
}

29
navalplanner-business/src/main/java/org/navalplanner/business/advance/entities/AdvanceType.java
View file

@ -26,11 +26,15 @@ import static org.navalplanner.business.i18n.I18nHelper._;
import java.math.BigDecimal;
import org.apache.commons.lang.BooleanUtils;
import org.apache.commons.lang.StringUtils;
import org.hibernate.validator.AssertTrue;
import org.hibernate.validator.NotEmpty;
import org.hibernate.validator.NotNull;
import org.navalplanner.business.advance.daos.IAdvanceTypeDAO;
import org.navalplanner.business.common.BaseEntity;
import org.navalplanner.business.common.IHumanIdentifiable;
import org.navalplanner.business.common.Registry;
import org.navalplanner.business.common.exceptions.InstanceNotFoundException;
import org.navalplanner.business.orders.entities.OrderElement;
/**
@ -61,7 +65,6 @@ public class AdvanceType extends BaseEntity implements IHumanIdentifiable{
unitPrecision, active, percentage, qualityForm));
}
@NotEmpty
private String unitName;
@NotNull
@ -81,6 +84,8 @@ public class AdvanceType extends BaseEntity implements IHumanIdentifiable{
private Boolean qualityForm = false;
private IAdvanceTypeDAO avanceTypeDAO = Registry.getAdvanceTypeDao();
/**
* Constructor for hibernate. Do not use!
*/
@ -106,6 +111,7 @@ public class AdvanceType extends BaseEntity implements IHumanIdentifiable{
this.unitName = unitName;
}
@NotEmpty(message = "unit name not specified")
public String getUnitName() {
return this.unitName;
}
@ -235,4 +241,25 @@ public class AdvanceType extends BaseEntity implements IHumanIdentifiable{
return unitName;
}
@AssertTrue(message = "the advance type name has to be unique. It is already used")
public boolean checkConstraintUniqueName() {
if (StringUtils.isBlank(unitName)) {
return true;
}
if (isNewObject()) {
return !avanceTypeDAO.existsByNameInAnotherTransaction(unitName);
} else {
return checkNotExistsOrIsTheSame();
}
}
private boolean checkNotExistsOrIsTheSame() {
try {
AdvanceType advanceType = avanceTypeDAO
.findUniqueByNameInAnotherTransaction(unitName);
return advanceType.getId().equals(getId());
} catch (InstanceNotFoundException e) {
return true;
}
}
}