From cbde05db74627044b88c4245d9fc9b25072e7eee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=93scar=20Gonz=C3=A1lez=20Fern=C3=A1ndez?= Date: Tue, 7 Jul 2009 20:00:37 +0200 Subject: [PATCH] ItEr16S12CreacionProxectoPlanificacion: the task elements collection of taskGroup cannot be modified. --- .../navalplanner/business/planner/entities/TaskGroup.java | 3 ++- .../navalplanner/business/test/planner/TaskGroupTest.java | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/navalplanner-business/src/main/java/org/navalplanner/business/planner/entities/TaskGroup.java b/navalplanner-business/src/main/java/org/navalplanner/business/planner/entities/TaskGroup.java index 99e30ba25..abfa15d72 100644 --- a/navalplanner-business/src/main/java/org/navalplanner/business/planner/entities/TaskGroup.java +++ b/navalplanner-business/src/main/java/org/navalplanner/business/planner/entities/TaskGroup.java @@ -1,6 +1,7 @@ package org.navalplanner.business.planner.entities; import java.util.ArrayList; +import java.util.Collections; import java.util.List; import org.apache.commons.lang.Validate; @@ -13,7 +14,7 @@ public class TaskGroup extends TaskElement { private List taskElements = new ArrayList(); public List getTaskElements() { - return taskElements; + return Collections.unmodifiableList(taskElements); } public void addTaskElement(TaskElement task) { diff --git a/navalplanner-business/src/test/java/org/navalplanner/business/test/planner/TaskGroupTest.java b/navalplanner-business/src/test/java/org/navalplanner/business/test/planner/TaskGroupTest.java index eed56ba63..acbc58b9b 100644 --- a/navalplanner-business/src/test/java/org/navalplanner/business/test/planner/TaskGroupTest.java +++ b/navalplanner-business/src/test/java/org/navalplanner/business/test/planner/TaskGroupTest.java @@ -42,4 +42,9 @@ public class TaskGroupTest { public void cantAddNullTaskElement() { taskGroup.addTaskElement(null); } + + @Test(expected = UnsupportedOperationException.class) + public void taskElementsCollectionCannotBeModified() { + taskGroup.getTaskElements().set(0, null); + } }