RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ItEr33S14CUCreacionUnidadesPlanificacion: Using assertTrue instead of checkValid for TaskMilestone

Browse source
This commit is contained in:
Óscar González Fernández 2009-11-04 21:14:09 +01:00
parent 0444259382
commit cf23877e8c
2 changed files with 6 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
navalplanner-business/src/main/java/org/navalplanner/business/planner/entities/TaskMilestone.java
View file

@ -26,16 +26,15 @@ import java.util.List;
import java.util.Set;
import org.apache.commons.lang.Validate;
import org.hibernate.validator.AssertTrue;
import org.joda.time.DateTime;
import org.joda.time.Days;
import org.navalplanner.business.common.IValidable;
import org.navalplanner.business.common.exceptions.ValidationException;
import org.navalplanner.business.orders.entities.OrderElement;
/**
* @author Lorenzo Tilve Álvaro <ltilve@igalia.com>
*/
public class TaskMilestone extends TaskElement implements IValidable {
public class TaskMilestone extends TaskElement {
public static TaskMilestone create() {
TaskMilestone milestone = new TaskMilestone();
@ -112,12 +111,10 @@ public class TaskMilestone extends TaskElement implements IValidable {
return Integer.valueOf(0);
}
@Override
public void checkValid() throws ValidationException {
if (super.getOrderElement() != null) {
throw new ValidationException("Not null milestone orderelement");
}
@SuppressWarnings("unused")
@AssertTrue(message = "order element associated to a milestone must be null")
private boolean theOrderElementMustBeNull() {
return getOrderElement() == null;
}
@Override

1
navalplanner-business/src/test/java/org/navalplanner/business/test/planner/daos/TaskElementDAOTest.java
View file

@ -109,7 +109,6 @@ public class TaskElementDAOTest {
order.setCode("code");
order.add(orderLine);
try {
order.checkValid();
orderDAO.save(order);
sessionFactory.getCurrentSession().flush();
} catch (ValidationException e) {