Revert "Added global zoom level session variable"

This reverts commit 235f6de48c.
This commit is contained in:
Manuel Rego Casasnovas 2013-02-06 13:42:52 +01:00
parent 800cf8b50d
commit dbc24f0833
5 changed files with 4 additions and 36 deletions

View file

@ -62,7 +62,6 @@ import org.zkoss.zk.mesg.MZk;
import org.zkoss.zk.ui.Component; import org.zkoss.zk.ui.Component;
import org.zkoss.zk.ui.Executions; import org.zkoss.zk.ui.Executions;
import org.zkoss.zk.ui.HtmlMacroComponent; import org.zkoss.zk.ui.HtmlMacroComponent;
import org.zkoss.zk.ui.Sessions;
import org.zkoss.zk.ui.UiException; import org.zkoss.zk.ui.UiException;
import org.zkoss.zk.ui.event.Event; import org.zkoss.zk.ui.event.Event;
import org.zkoss.zk.ui.event.EventListener; import org.zkoss.zk.ui.event.EventListener;
@ -278,9 +277,7 @@ public class Planner extends HtmlMacroComponent {
return; return;
} }
this.fixedZoomByUser = true; this.fixedZoomByUser = true;
initialZoomLevel = zoomLevel; initialZoomLevel = zoomLevel;
Sessions.getCurrent().setAttribute("zoomLevel", zoomLevel);
ganttPanel.setZoomLevel(zoomLevel, scrollLeft); ganttPanel.setZoomLevel(zoomLevel, scrollLeft);
} }
@ -412,7 +409,8 @@ public class Planner extends HtmlMacroComponent {
if (command.equals("onZoomLevelChange")){ if (command.equals("onZoomLevelChange")){
zoomindex= (Integer) retrieveData(request, "zoomindex"); zoomindex= (Integer) retrieveData(request, "zoomindex");
scrollLeft = (Integer) retrieveData(request, "scrollLeft"); scrollLeft = (Integer) retrieveData(request, "scrollLeft");
setZoomLevel((ZoomLevel) ((Listbox) getFellow("listZoomLevels"))
setZoomLevel((ZoomLevel)((Listbox)getFellow("listZoomLevels"))
.getModel().getElementAt(zoomindex), .getModel().getElementAt(zoomindex),
scrollLeft); scrollLeft);
return true; return true;

View file

@ -110,11 +110,6 @@ public class CompanyPlanningController implements Composer {
&& !(parameters.isEmpty())) { && !(parameters.isEmpty())) {
zoomLevelParameter = parameters.get("zoom")[0]; zoomLevelParameter = parameters.get("zoom")[0];
} }
ZoomLevel sessionZoom = (ZoomLevel) Sessions.getCurrent().getAttribute(
"zoomLevel");
if (sessionZoom != null) {
zoomLevelParameter = sessionZoom.getInternalName();
}
if (zoomLevelParameter != null) { if (zoomLevelParameter != null) {
planner.setInitialZoomLevel(ZoomLevel planner.setInitialZoomLevel(ZoomLevel
.getFromString(zoomLevelParameter)); .getFromString(zoomLevelParameter));

View file

@ -233,11 +233,8 @@ public class CompanyPlanningModel implements ICompanyPlanningModel {
addPrintSupport(configuration); addPrintSupport(configuration);
disableSomeFeatures(configuration); disableSomeFeatures(configuration);
ZoomLevel defaultZoomLevel = sessionGetZoomLevel(); ZoomLevel defaultZoomLevel = OrderPlanningModel
if (defaultZoomLevel == null) {
defaultZoomLevel = OrderPlanningModel
.calculateDefaultLevel(configuration); .calculateDefaultLevel(configuration);
}
OrderPlanningModel.configureInitialZoomLevelFor(planner, OrderPlanningModel.configureInitialZoomLevelFor(planner,
defaultZoomLevel); defaultZoomLevel);
@ -270,16 +267,6 @@ public class CompanyPlanningModel implements ICompanyPlanningModel {
} }
} }
private ZoomLevel sessionGetZoomLevel() {
return (ZoomLevel) Sessions.getCurrent().getAttribute("zoomLevel");
}
private void sessionSetZoomLevel(ZoomLevel level) {
if (level != null) {
Sessions.getCurrent().setAttribute("zoomLevel", level);
}
}
private BaseCalendar getDefaultCalendar() { private BaseCalendar getDefaultCalendar() {
return configurationDAO.getConfiguration().getDefaultCalendar(); return configurationDAO.getConfiguration().getDefaultCalendar();
} }
@ -676,7 +663,7 @@ public class CompanyPlanningModel implements ICompanyPlanningModel {
@Override @Override
public void zoomLevelChanged(ZoomLevel detailLevel) { public void zoomLevelChanged(ZoomLevel detailLevel) {
loadChart.setZoomLevel(detailLevel); loadChart.setZoomLevel(detailLevel);
sessionSetZoomLevel(detailLevel);
transactionService transactionService
.runOnReadOnlyTransaction(new IOnTransaction<Void>() { .runOnReadOnlyTransaction(new IOnTransaction<Void>() {
@Override @Override

View file

@ -173,12 +173,6 @@ public class OrderPlanningController implements Composer {
&& !(parameters.isEmpty())) { && !(parameters.isEmpty())) {
zoomLevelParameter = parameters.get("zoom")[0]; zoomLevelParameter = parameters.get("zoom")[0];
} }
ZoomLevel sessionZoom = (ZoomLevel) Sessions.getCurrent().getAttribute(
"zoomLevel");
if (sessionZoom != null) {
zoomLevelParameter = sessionZoom.getInternalName();
}
if (zoomLevelParameter != null) { if (zoomLevelParameter != null) {
planner.setInitialZoomLevel(ZoomLevel planner.setInitialZoomLevel(ZoomLevel
.getFromString(zoomLevelParameter)); .getFromString(zoomLevelParameter));

View file

@ -123,7 +123,6 @@ import org.zkoss.ganttz.timetracker.zoom.ZoomLevel;
import org.zkoss.ganttz.util.Interval; import org.zkoss.ganttz.util.Interval;
import org.zkoss.ganttz.util.ProfilingLogFactory; import org.zkoss.ganttz.util.ProfilingLogFactory;
import org.zkoss.zk.ui.Executions; import org.zkoss.zk.ui.Executions;
import org.zkoss.zk.ui.Sessions;
import org.zkoss.zk.ui.WrongValueException; import org.zkoss.zk.ui.WrongValueException;
import org.zkoss.zk.ui.event.Event; import org.zkoss.zk.ui.event.Event;
import org.zkoss.zk.ui.event.EventListener; import org.zkoss.zk.ui.event.EventListener;
@ -1175,7 +1174,6 @@ public class OrderPlanningModel implements IOrderPlanningModel {
@Override @Override
public void zoomLevelChanged(ZoomLevel detailLevel) { public void zoomLevelChanged(ZoomLevel detailLevel) {
loadChart.setZoomLevel(detailLevel); loadChart.setZoomLevel(detailLevel);
sessionStoreZoomLevel(detailLevel);
transactionService transactionService
.runOnReadOnlyTransaction(new IOnTransaction<Void>() { .runOnReadOnlyTransaction(new IOnTransaction<Void>() {
@ -1191,10 +1189,6 @@ public class OrderPlanningModel implements IOrderPlanningModel {
} }
}); });
} }
private void sessionStoreZoomLevel(ZoomLevel detailLevel) {
Sessions.getCurrent().setAttribute("zoomLevel", detailLevel);
}
}; };
keepAliveZoomListeners.add(zoomListener); keepAliveZoomListeners.add(zoomListener);