From dc791ca74d3f81f61ba0c24ce0a03e71ff567ab8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=93scar=20Gonz=C3=A1lez=20Fern=C3=A1ndez?=
 <ogonzalez@igalia.com>
Date: Wed, 28 Oct 2009 12:25:38 +0100
Subject: [PATCH] Extracting methods

---
 .../planner/daos/DayAssignmentDAO.java        | 47 +++++++++++--------
 1 file changed, 28 insertions(+), 19 deletions(-)

diff --git a/navalplanner-business/src/main/java/org/navalplanner/business/planner/daos/DayAssignmentDAO.java b/navalplanner-business/src/main/java/org/navalplanner/business/planner/daos/DayAssignmentDAO.java
index 15a1aba9f..e8b33b8f1 100644
--- a/navalplanner-business/src/main/java/org/navalplanner/business/planner/daos/DayAssignmentDAO.java
+++ b/navalplanner-business/src/main/java/org/navalplanner/business/planner/daos/DayAssignmentDAO.java
@@ -20,7 +20,8 @@
 
 package org.navalplanner.business.planner.daos;
 
-import java.util.HashSet;
+import java.util.ArrayList;
+import java.util.Collection;
 import java.util.List;
 import java.util.Set;
 import java.util.SortedMap;
@@ -31,6 +32,7 @@ import org.hibernate.criterion.Projections;
 import org.hibernate.criterion.Property;
 import org.hibernate.criterion.Restrictions;
 import org.joda.time.LocalDate;
+import org.navalplanner.business.common.BaseEntity;
 import org.navalplanner.business.common.daos.GenericDAOHibernate;
 import org.navalplanner.business.planner.entities.DayAssignment;
 import org.navalplanner.business.planner.entities.GenericDayAssignment;
@@ -64,24 +66,10 @@ public class DayAssignmentDAO extends GenericDAOHibernate<DayAssignment, Long>
         Set<ResourceAllocation<?>> resourceAllocations = taskElement
                 .getResourceAllocations();
 
-        Set<GenericResourceAllocation> genericResourceAllocations = new HashSet<GenericResourceAllocation>();
-        Set<SpecificResourceAllocation> specificResourceAllocations = new HashSet<SpecificResourceAllocation>();
-
-        for (ResourceAllocation<?> resourceAllocation : resourceAllocations) {
-            if (resourceAllocation instanceof GenericResourceAllocation) {
-                Long id = resourceAllocation.getId();
-                if (id != null) {
-                    genericResourceAllocations
-                            .add((GenericResourceAllocation) resourceAllocation);
-                }
-            } else if (resourceAllocation instanceof SpecificResourceAllocation) {
-                Long id = resourceAllocation.getId();
-                if (id != null) {
-                    specificResourceAllocations
-                            .add((SpecificResourceAllocation) resourceAllocation);
-                }
-            }
-        }
+        List<GenericResourceAllocation> genericResourceAllocations = withId(getOfType(
+                GenericResourceAllocation.class, resourceAllocations));
+        List<SpecificResourceAllocation> specificResourceAllocations = withId(getOfType(
+                SpecificResourceAllocation.class, resourceAllocations));
 
         if (!genericResourceAllocations.isEmpty()) {
             Criteria criteria = getSession().createCriteria(
@@ -129,4 +117,25 @@ public class DayAssignmentDAO extends GenericDAOHibernate<DayAssignment, Long>
         return result;
     }
 
+    private <T extends BaseEntity> List<T> withId(List<T> elements) {
+        List<T> result = new ArrayList<T>();
+        for (T element : elements) {
+            if (element.getId() != null) {
+                result.add(element);
+            }
+        }
+        return result;
+    }
+
+    private <T extends ResourceAllocation<?>> List<T> getOfType(Class<T> type,
+            Collection<? extends ResourceAllocation<?>> resourceAllocations) {
+        List<T> result = new ArrayList<T>();
+        for (ResourceAllocation<?> allocation : resourceAllocations) {
+            if (type.isInstance(allocation)) {
+                result.add(type.cast(allocation));
+            }
+        }
+        return result;
+    }
+
 }