From df1e08286361acc3f7489d5a2964d79a81291942 Mon Sep 17 00:00:00 2001 From: Diego Pino Garcia Date: Sat, 26 Dec 2009 13:55:58 +0100 Subject: [PATCH] ItEr40S17CUInformeListaAvancesTrabajoItEr39S20: Fix bugs in workingProgressPerTask report and completedEstimatedHoursPerTask report * No data shown on reports * Correct layout in reports * Change deadline date to reference date --- .../business/planner/daos/TaskElementDAO.java | 9 +- .../dtos/WorkingProgressPerTaskDTO.java | 2 +- .../main/jasper/completedEstimatedHours.jrxml | 12 +- .../jasper/workingProgressPerTaskReport.jrxml | 363 +++++++++--------- .../web/common/CustomMenuController.java | 2 +- ...pletedEstimatedHoursPerTaskController.java | 10 +- .../ICompletedEstimatedHoursPerTaskModel.java | 2 +- .../reports/IWorkingProgressPerTaskModel.java | 2 +- .../WorkingProgressPerTaskController.java | 10 +- .../reports/WorkingProgressPerTaskModel.java | 4 +- .../completedEstimatedHoursPerTask.zul | 4 +- .../reports/workingProgressPerTaskReport.zul | 4 +- 12 files changed, 215 insertions(+), 209 deletions(-) diff --git a/navalplanner-business/src/main/java/org/navalplanner/business/planner/daos/TaskElementDAO.java b/navalplanner-business/src/main/java/org/navalplanner/business/planner/daos/TaskElementDAO.java index a74969788..4b9ae41b4 100644 --- a/navalplanner-business/src/main/java/org/navalplanner/business/planner/daos/TaskElementDAO.java +++ b/navalplanner-business/src/main/java/org/navalplanner/business/planner/daos/TaskElementDAO.java @@ -111,20 +111,16 @@ public class TaskElementDAO extends GenericDAOHibernate private List getTasksByOrderAndDate(Order order, LocalDate deadline) { - if (deadline == null) { - deadline = new LocalDate(); - } - final List orders = (order != null) ? order .getOrderElements() : new ArrayList(); + // Prepare query String strQuery = "SELECT task " + "FROM TaskSource taskSource " + "LEFT OUTER JOIN taskSource.task task " + "LEFT OUTER JOIN taskSource.orderElement orderElement " - + "WHERE task IN (SELECT task FROM Task task) " - + "AND task.deadline <= :deadline "; + + "WHERE task IN (SELECT task FROM Task task) "; if (orders != null && !orders.isEmpty()) { strQuery += "AND orderElement IN (:orders) "; @@ -132,7 +128,6 @@ public class TaskElementDAO extends GenericDAOHibernate // Execute query Query query = getSession().createQuery(strQuery); - query.setParameter("deadline", deadline); if (orders != null && !orders.isEmpty()) { query.setParameterList("orders", orders); } diff --git a/navalplanner-business/src/main/java/org/navalplanner/business/reports/dtos/WorkingProgressPerTaskDTO.java b/navalplanner-business/src/main/java/org/navalplanner/business/reports/dtos/WorkingProgressPerTaskDTO.java index ef9282824..74225993b 100644 --- a/navalplanner-business/src/main/java/org/navalplanner/business/reports/dtos/WorkingProgressPerTaskDTO.java +++ b/navalplanner-business/src/main/java/org/navalplanner/business/reports/dtos/WorkingProgressPerTaskDTO.java @@ -76,7 +76,7 @@ public class WorkingProgressPerTaskDTO { this.totalPlannedHours = calculatePlannedHours(task, null); this.partialPlannedHours = calculatePlannedHours(task, date); this.realHours = calculateRealHours(task, date); - this.averageProgress = task.getOrderElement().getAdvancePercentage(); + this.averageProgress = task.getOrderElement().getAdvancePercentage(date); this.imputedProgress = (totalPlannedHours != 0) ? new Double(realHours / totalPlannedHours.doubleValue()) : new Double(0); this.plannedProgress = (totalPlannedHours != 0) ? new Double(partialPlannedHours / totalPlannedHours.doubleValue()) : new Double(0); diff --git a/navalplanner-webapp/src/main/jasper/completedEstimatedHours.jrxml b/navalplanner-webapp/src/main/jasper/completedEstimatedHours.jrxml index 3767a7143..21522eb0a 100644 --- a/navalplanner-webapp/src/main/jasper/completedEstimatedHours.jrxml +++ b/navalplanner-webapp/src/main/jasper/completedEstimatedHours.jrxml @@ -4,7 +4,7 @@