RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve error reporting for snapshots

Browse source 
If an error was produced calculating a snapshot, the error was
reported when the snapshot was retrieved. Now the error is also
reported as soon it happens.

FEA: ItEr62S05BugFixing
This commit is contained in:
Óscar González Fernández 2010-10-11 20:36:28 +02:00
parent 8364d68019
commit dfd824cfd2
1 changed files with 23 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
navalplanner-business/src/main/java/org/navalplanner/business/hibernate/notification/NotBlockingAutoUpdatedSnapshot.java
View file

@ -226,11 +226,15 @@ class NotBlockingAutoUpdatedSnapshot<T> implements IAutoUpdatedSnapshot<T> {
public T call() throws Exception {
long start = System.currentTimeMillis();
long timeWaiting = start - requestTime;
Exception error = null;
try {
return callable.call();
} catch (Exception e) {
error = e;
throw e;
} finally {
long timeExecuting = System.currentTimeMillis() - start;
executionsReport.newData(timeWaiting, timeExecuting);
executionsReport.newData(timeWaiting, timeExecuting, error);
}
}
};
@ -238,18 +242,21 @@ class NotBlockingAutoUpdatedSnapshot<T> implements IAutoUpdatedSnapshot<T> {
private static class Data {
final int executionTimes;
final int errors;
long totalMsWaiting;
long totalMsExecuting;
private Data(int executionTimes, long totalMsWaiting,
private Data(int executionTimes, int errors, long totalMsWaiting,
long totalMsExecuting) {
this.executionTimes = executionTimes;
this.totalMsWaiting = totalMsWaiting;
this.totalMsExecuting = totalMsExecuting;
this.errors = errors;
}
public Data newData(long timeWaiting, long timeExcuting) {
return new Data(executionTimes + 1, totalMsWaiting + timeWaiting,
public Data newData(long timeWaiting, long timeExcuting, Exception e) {
return new Data(executionTimes + 1, errors + (e != null ? 1 : 0),
totalMsWaiting + timeWaiting,
totalMsExecuting + timeExcuting);
}
@ -258,20 +265,26 @@ class NotBlockingAutoUpdatedSnapshot<T> implements IAutoUpdatedSnapshot<T> {
private class ExecutionsReport {
private AtomicReference<Data> data = new AtomicReference<Data>(
new Data(0, 0, 0));
new Data(0, 0, 0, 0));
public void newData(long timeWaiting, long timeExecuting) {
public void newData(long timeWaiting, long timeExecuting,
Exception possibleError) {
Data previousData;
Data newData;
do {
previousData = data.get();
newData = previousData.newData(timeWaiting, timeExecuting);
newData = previousData.newData(timeWaiting, timeExecuting,
possibleError);
} while (!data.compareAndSet(previousData, newData));
report(timeWaiting, timeExecuting, newData);
report(timeWaiting, timeExecuting, newData, possibleError);
}
private void report(long timeWaiting, long timeExecuting, Data data) {
private void report(long timeWaiting, long timeExecuting, Data data,
Exception possibleError) {
LOG.info(name + " took " + timeExecuting + " ms executing");
if (possibleError != null) {
LOG.error("error loading " + name, possibleError);
}
LOG.info(name + " waited for " + timeWaiting
+ " ms until executing");
LOG.info(name + " mean time waiting for execution: "
@ -280,6 +293,7 @@ class NotBlockingAutoUpdatedSnapshot<T> implements IAutoUpdatedSnapshot<T> {
+ data.totalMsExecuting / data.executionTimes + " ms");
LOG.info(name + " has been executed " + data.executionTimes
+ " times");
LOG.info(name + " has produced errors " + data.errors + " times");
}
}