From e1bf121b4ccebefe9c6ea7ab6e7d2400b3da75c5 Mon Sep 17 00:00:00 2001
From: Manuel Rego Casasnovas <rego@igalia.com>
Date: Wed, 30 Jan 2013 11:45:45 +0100
Subject: [PATCH] jira-integration: Use Collections.unmodifiableList in
 JiraSyncInfo

In order to simply code of JiraSyncInfo it has been used the method
Collections.unmodifiableList. Moreover, the type of syncFailedReasons has been
changed to List to make it easier.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
---
 .../main/java/org/libreplan/importers/JiraSyncInfo.java  | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/libreplan-webapp/src/main/java/org/libreplan/importers/JiraSyncInfo.java b/libreplan-webapp/src/main/java/org/libreplan/importers/JiraSyncInfo.java
index 62cc6aa1d..fecf80d95 100644
--- a/libreplan-webapp/src/main/java/org/libreplan/importers/JiraSyncInfo.java
+++ b/libreplan-webapp/src/main/java/org/libreplan/importers/JiraSyncInfo.java
@@ -20,9 +20,8 @@
 package org.libreplan.importers;
 
 import java.util.ArrayList;
-import java.util.HashSet;
+import java.util.Collections;
 import java.util.List;
-import java.util.Set;
 
 /**
  * Keeps track the synchronization info.
@@ -31,7 +30,7 @@ import java.util.Set;
  */
 public class JiraSyncInfo {
 
-    private Set<String> syncFailedReasons = new HashSet<String>();
+    private List<String> syncFailedReasons = new ArrayList<String>();
 
     /**
      * Add the specified <code>reason</code> to syncFailedReasons list
@@ -56,9 +55,7 @@ public class JiraSyncInfo {
      * returns reasons why synchronization is failed
      */
     public List<String> getSyncFailedReasons() {
-        List<String> failedReasons = new ArrayList<String>();
-        failedReasons.addAll(syncFailedReasons);
-        return failedReasons;
+        return Collections.unmodifiableList(syncFailedReasons);
     }
 
 }