RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not take into account work report lines with effort zero for task completion chart

Browse source 
FEA: ItEr76S04BugFixing
This commit is contained in:
Manuel Rego Casasnovas 2012-07-13 12:49:42 +02:00
parent f4e6f6f59b
commit e4e1479d5f
1 changed files with 20 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
libreplan-business/src/main/java/org/libreplan/business/planner/entities/visitors/CalculateFinishedTasksLagInCompletionVisitor.java
View file

@ -25,6 +25,7 @@ package org.libreplan.business.planner.entities.visitors;
* @author Nacho Barrientos <nacho@igalia.com>
*/
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import org.joda.time.Days;
@ -52,15 +53,29 @@ public class CalculateFinishedTasksLagInCompletionVisitor extends TaskElementVis
List<WorkReportLine> workReportLines = task.
getOrderElement().getWorkReportLines(true);
if (workReportLines.size() > 0) {
LocalDate lastRLDate = LocalDate.fromDateFields(
workReportLines.get(workReportLines.size()-1).getDate());
LocalDate endDate = task.getEndAsLocalDate();
deviations.add((double)Days.
daysBetween(endDate, lastRLDate).getDays());
WorkReportLine last = getLastWorkReportLineWithEffortDurationNoZero(workReportLines);
if (last != null) {
LocalDate lastRLDate = LocalDate.fromDateFields(last
.getDate());
LocalDate endDate = task.getEndAsLocalDate();
deviations.add((double) Days.daysBetween(endDate,
lastRLDate).getDays());
}
}
}
}
private WorkReportLine getLastWorkReportLineWithEffortDurationNoZero(
List<WorkReportLine> workReportLines) {
Collections.reverse(workReportLines);
for (WorkReportLine each : workReportLines) {
if (!each.getEffort().isZero()) {
return each;
}
}
return null;
}
public void visit(TaskGroup taskGroup) {
for (TaskElement each: taskGroup.getChildren()) {
each.acceptVisitor(this);