diff --git a/libreplan-business/src/main/java/org/libreplan/business/workingday/IntraDayDate.java b/libreplan-business/src/main/java/org/libreplan/business/workingday/IntraDayDate.java
index 217bc4461..24aa5a9ed 100644
--- a/libreplan-business/src/main/java/org/libreplan/business/workingday/IntraDayDate.java
+++ b/libreplan-business/src/main/java/org/libreplan/business/workingday/IntraDayDate.java
@@ -33,8 +33,8 @@ import java.util.Iterator;
import java.util.List;
import java.util.NoSuchElementException;
-import org.apache.commons.lang.Validate;
-import org.apache.commons.lang.builder.HashCodeBuilder;
+import org.apache.commons.lang3.Validate;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
import javax.validation.constraints.NotNull;
import org.joda.time.DateTime;
import org.joda.time.Days;
diff --git a/libreplan-business/src/main/java/org/libreplan/business/workingday/ResourcesPerDay.java b/libreplan-business/src/main/java/org/libreplan/business/workingday/ResourcesPerDay.java
index d27a8b736..7eb33c822 100644
--- a/libreplan-business/src/main/java/org/libreplan/business/workingday/ResourcesPerDay.java
+++ b/libreplan-business/src/main/java/org/libreplan/business/workingday/ResourcesPerDay.java
@@ -24,7 +24,7 @@ package org.libreplan.business.workingday;
import java.math.BigDecimal;
import java.math.RoundingMode;
-import org.apache.commons.lang.Validate;
+import org.apache.commons.lang3.Validate;
import org.libreplan.business.common.ProportionalDistributor;
import org.libreplan.business.workingday.EffortDuration.Granularity;
diff --git a/libreplan-business/src/main/java/org/libreplan/business/workingday/hibernate/EffortDurationType.java b/libreplan-business/src/main/java/org/libreplan/business/workingday/hibernate/EffortDurationType.java
index 4ae3f7f23..6431edb9d 100644
--- a/libreplan-business/src/main/java/org/libreplan/business/workingday/hibernate/EffortDurationType.java
+++ b/libreplan-business/src/main/java/org/libreplan/business/workingday/hibernate/EffortDurationType.java
@@ -25,8 +25,8 @@ import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Types;
+import java.util.Objects;
-import org.apache.commons.lang.ObjectUtils;
import org.hibernate.HibernateException;
import org.hibernate.engine.spi.SessionImplementor;
import org.hibernate.type.StandardBasicTypes;
@@ -50,7 +50,7 @@ public class EffortDurationType implements UserType {
@Override
public boolean equals(Object x, Object y) throws HibernateException {
- return ObjectUtils.equals(x, y);
+ return Objects.equals(x, y);
}
@Override
diff --git a/libreplan-business/src/main/java/org/libreplan/business/workreports/daos/WorkReportTypeDAO.java b/libreplan-business/src/main/java/org/libreplan/business/workreports/daos/WorkReportTypeDAO.java
index 99aa14259..00df90aeb 100644
--- a/libreplan-business/src/main/java/org/libreplan/business/workreports/daos/WorkReportTypeDAO.java
+++ b/libreplan-business/src/main/java/org/libreplan/business/workreports/daos/WorkReportTypeDAO.java
@@ -23,7 +23,7 @@ package org.libreplan.business.workreports.daos;
import java.util.List;
-import org.apache.commons.lang.Validate;
+import org.apache.commons.lang3.Validate;
import org.hibernate.Criteria;
import org.hibernate.NonUniqueResultException;
import org.hibernate.criterion.Restrictions;
diff --git a/libreplan-business/src/main/java/org/libreplan/business/workreports/entities/WorkReport.java b/libreplan-business/src/main/java/org/libreplan/business/workreports/entities/WorkReport.java
index dd0d97448..6677c8fb3 100644
--- a/libreplan-business/src/main/java/org/libreplan/business/workreports/entities/WorkReport.java
+++ b/libreplan-business/src/main/java/org/libreplan/business/workreports/entities/WorkReport.java
@@ -28,8 +28,8 @@ import java.util.HashSet;
import java.util.Map;
import java.util.Set;
-import org.apache.commons.lang.StringUtils;
-import org.apache.commons.lang.Validate;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.Validate;
import javax.validation.constraints.AssertTrue;
import javax.validation.constraints.NotNull;
import javax.validation.Valid;
diff --git a/libreplan-business/src/main/java/org/libreplan/business/workreports/entities/WorkReportLine.java b/libreplan-business/src/main/java/org/libreplan/business/workreports/entities/WorkReportLine.java
index 87a3f8a4f..27998fd91 100644
--- a/libreplan-business/src/main/java/org/libreplan/business/workreports/entities/WorkReportLine.java
+++ b/libreplan-business/src/main/java/org/libreplan/business/workreports/entities/WorkReportLine.java
@@ -26,7 +26,7 @@ import java.util.HashSet;
import java.util.List;
import java.util.Set;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
import javax.validation.constraints.AssertTrue;
import javax.validation.constraints.NotNull;
import javax.validation.Valid;
diff --git a/libreplan-business/src/main/java/org/libreplan/business/workreports/entities/WorkReportType.java b/libreplan-business/src/main/java/org/libreplan/business/workreports/entities/WorkReportType.java
index 36ce1f2c3..8f284c903 100644
--- a/libreplan-business/src/main/java/org/libreplan/business/workreports/entities/WorkReportType.java
+++ b/libreplan-business/src/main/java/org/libreplan/business/workreports/entities/WorkReportType.java
@@ -26,7 +26,7 @@ import java.util.HashSet;
import java.util.List;
import java.util.Set;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
import org.hibernate.NonUniqueResultException;
import javax.validation.constraints.AssertTrue;
import org.hibernate.validator.constraints.NotEmpty;
diff --git a/libreplan-business/src/test/java/org/libreplan/business/test/calendars/entities/AvailabilityTimeLineTest.java b/libreplan-business/src/test/java/org/libreplan/business/test/calendars/entities/AvailabilityTimeLineTest.java
index de3db5bd0..73c7b47a8 100644
--- a/libreplan-business/src/test/java/org/libreplan/business/test/calendars/entities/AvailabilityTimeLineTest.java
+++ b/libreplan-business/src/test/java/org/libreplan/business/test/calendars/entities/AvailabilityTimeLineTest.java
@@ -29,7 +29,7 @@ import static org.junit.Assert.assertTrue;
import java.util.ArrayList;
import java.util.List;
-import org.apache.commons.lang.Validate;
+import org.apache.commons.lang3.Validate;
import org.hamcrest.BaseMatcher;
import org.hamcrest.Description;
import org.hamcrest.Matcher;
diff --git a/libreplan-business/src/test/java/org/libreplan/business/test/calendars/entities/BaseCalendarTest.java b/libreplan-business/src/test/java/org/libreplan/business/test/calendars/entities/BaseCalendarTest.java
index 60fa88e39..b7463ac01 100644
--- a/libreplan-business/src/test/java/org/libreplan/business/test/calendars/entities/BaseCalendarTest.java
+++ b/libreplan-business/src/test/java/org/libreplan/business/test/calendars/entities/BaseCalendarTest.java
@@ -777,7 +777,7 @@ public class BaseCalendarTest {
ResourcesPerDay.amount(2)), equalTo(hours(16)));
}
- @Test(expected = IllegalArgumentException.class)
+ @Test(expected = NullPointerException.class)
public void getCapacityWithOvertimeMustNotBeCalledWithANullDate() {
BaseCalendar calendar = createBasicCalendar();
calendar.getCapacityWithOvertime(null);
diff --git a/libreplan-business/src/test/java/org/libreplan/business/test/calendars/entities/CombinedWorkHoursTest.java b/libreplan-business/src/test/java/org/libreplan/business/test/calendars/entities/CombinedWorkHoursTest.java
index f9c55f64b..1451216c5 100644
--- a/libreplan-business/src/test/java/org/libreplan/business/test/calendars/entities/CombinedWorkHoursTest.java
+++ b/libreplan-business/src/test/java/org/libreplan/business/test/calendars/entities/CombinedWorkHoursTest.java
@@ -39,7 +39,7 @@ import org.libreplan.business.workingday.IntraDayDate.PartialDay;
public class CombinedWorkHoursTest {
- @Test(expected = IllegalArgumentException.class)
+ @Test(expected = NullPointerException.class)
public void cannotAcceptOnlyNullElements() {
ICalendar[] nullWorkHours = null;
CombinedWorkHours.minOf(nullWorkHours);
diff --git a/libreplan-business/src/test/java/org/libreplan/business/test/orders/daos/OrderElementDAOTest.java b/libreplan-business/src/test/java/org/libreplan/business/test/orders/daos/OrderElementDAOTest.java
index 680b5d3a3..45b4a4a36 100644
--- a/libreplan-business/src/test/java/org/libreplan/business/test/orders/daos/OrderElementDAOTest.java
+++ b/libreplan-business/src/test/java/org/libreplan/business/test/orders/daos/OrderElementDAOTest.java
@@ -429,10 +429,8 @@ public class OrderElementDAOTest {
@Test
@Transactional
public void testCheckUniqueQualityForm() {
- OrderElement orderElement = OrderElementTest
- .givenOrderLineGroupWithTwoOrderLines(2000, 3000);
- QualityForm qualityForm = QualityForm.create(UUID.randomUUID()
- .toString(), UUID.randomUUID().toString());
+ OrderElement orderElement = OrderElementTest.givenOrderLineGroupWithTwoOrderLines(2000, 3000);
+ QualityForm qualityForm = QualityForm.create(UUID.randomUUID().toString(), UUID.randomUUID().toString());
orderElement.addTaskQualityForm(qualityForm);
assertThat(orderElement.getTaskQualityForms().size(), equalTo(1));
@@ -440,7 +438,7 @@ public class OrderElementDAOTest {
try {
orderElement.addTaskQualityForm(null);
fail("It should throw an exception");
- } catch (IllegalArgumentException e) {
+ } catch (NullPointerException e) {
// ok
}
diff --git a/libreplan-business/src/test/java/org/libreplan/business/test/orders/entities/OrderElementTest.java b/libreplan-business/src/test/java/org/libreplan/business/test/orders/entities/OrderElementTest.java
index 07e4bb2be..57e3b56d3 100644
--- a/libreplan-business/src/test/java/org/libreplan/business/test/orders/entities/OrderElementTest.java
+++ b/libreplan-business/src/test/java/org/libreplan/business/test/orders/entities/OrderElementTest.java
@@ -45,7 +45,7 @@ import javax.validation.ConstraintViolation;
import javax.validation.Validation;
import javax.validation.Validator;
-import org.apache.commons.lang.Validate;
+import org.apache.commons.lang3.Validate;
import org.hamcrest.BaseMatcher;
import org.hamcrest.Description;
import org.hamcrest.Matcher;
diff --git a/libreplan-business/src/test/java/org/libreplan/business/test/planner/chart/ContiguousDaysLineTest.java b/libreplan-business/src/test/java/org/libreplan/business/test/planner/chart/ContiguousDaysLineTest.java
index f0a6c9ee0..b25c024fb 100644
--- a/libreplan-business/src/test/java/org/libreplan/business/test/planner/chart/ContiguousDaysLineTest.java
+++ b/libreplan-business/src/test/java/org/libreplan/business/test/planner/chart/ContiguousDaysLineTest.java
@@ -7,8 +7,8 @@ import static org.junit.Assert.assertTrue;
import java.util.ArrayList;
import java.util.List;
+import java.util.Objects;
-import org.apache.commons.lang.ObjectUtils;
import org.hamcrest.BaseMatcher;
import org.hamcrest.Description;
import org.hamcrest.Matcher;
@@ -72,7 +72,7 @@ public class ContiguousDaysLineTest {
if (object instanceof ContiguousDaysLine) {
ContiguousDaysLine> line = (ContiguousDaysLine) object;
for (OnDay> each : line) {
- if(! ObjectUtils.equals(value, each.getValue())){
+ if(! Objects.equals(value, each.getValue())){
return false;
}
}
@@ -179,7 +179,7 @@ public class ContiguousDaysLineTest {
if (object instanceof ContiguousDaysLine) {
ContiguousDaysLine> another = (ContiguousDaysLine>) object;
for (OnDay> each : line) {
- if (!ObjectUtils.equals(each.getValue(),
+ if (!Objects.equals(each.getValue(),
another.get(each.getDay()))) {
return false;
}
diff --git a/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/AggregateOfResourceAllocationsTest.java b/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/AggregateOfResourceAllocationsTest.java
index 9f89d5b5b..c5306f491 100644
--- a/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/AggregateOfResourceAllocationsTest.java
+++ b/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/AggregateOfResourceAllocationsTest.java
@@ -44,7 +44,7 @@ public class AggregateOfResourceAllocationsTest {
private AggregateOfResourceAllocations aggregate;
- @Test(expected = IllegalArgumentException.class)
+ @Test(expected = NullPointerException.class)
public void doesntAcceptNullResourceAllocations() {
AggregateOfResourceAllocations.createFromSatisfied(null);
}
diff --git a/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/DependencyTest.java b/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/DependencyTest.java
index 960324ef5..542cd3dbe 100644
--- a/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/DependencyTest.java
+++ b/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/DependencyTest.java
@@ -75,7 +75,7 @@ public class DependencyTest {
try {
Dependency.create(origin, destination, type);
fail("must send IllegalArgumentException");
- } catch (IllegalArgumentException e) {
+ } catch (NullPointerException e) {
// ok
}
}
diff --git a/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/DerivedAllocationGeneratorTest.java b/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/DerivedAllocationGeneratorTest.java
index 6abe221d6..7101a7335 100644
--- a/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/DerivedAllocationGeneratorTest.java
+++ b/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/DerivedAllocationGeneratorTest.java
@@ -179,7 +179,7 @@ public class DerivedAllocationGeneratorTest {
return dayAssignment;
}
- @Test(expected = IllegalArgumentException.class)
+ @Test(expected = NullPointerException.class)
public void derivedFromMustBeNotNull() {
givenFinder();
givenConfigurationUnit();
@@ -187,7 +187,7 @@ public class DerivedAllocationGeneratorTest {
DerivedAllocationGenerator.generate(derivedFrom, finder, configurationUnit, dayAssignments);
}
- @Test(expected = IllegalArgumentException.class)
+ @Test(expected = NullPointerException.class)
public void finderMustBeNotNull() {
givenDerivedFrom();
givenConfigurationUnit();
@@ -195,7 +195,7 @@ public class DerivedAllocationGeneratorTest {
DerivedAllocationGenerator.generate(derivedFrom, finder, configurationUnit, dayAssignments);
}
- @Test(expected = IllegalArgumentException.class)
+ @Test(expected = NullPointerException.class)
public void configurationUnitMustBeNotNull() {
givenDerivedFrom();
givenFinder();
@@ -203,7 +203,7 @@ public class DerivedAllocationGeneratorTest {
DerivedAllocationGenerator.generate(derivedFrom, finder, configurationUnit, dayAssignments);
}
- @Test(expected = IllegalArgumentException.class)
+ @Test(expected = NullPointerException.class)
public void dayAssignmentsMustBeNotNull() {
givenDerivedFrom();
givenFinder();
diff --git a/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/DerivedAllocationTest.java b/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/DerivedAllocationTest.java
index 87f27b339..1c931d387 100644
--- a/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/DerivedAllocationTest.java
+++ b/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/DerivedAllocationTest.java
@@ -148,13 +148,13 @@ public class DerivedAllocationTest {
DerivedAllocation.create(derivedFrom, configurationUnit);
}
- @Test(expected = IllegalArgumentException.class)
+ @Test(expected = NullPointerException.class)
public void theDerivedFromMustBeNotNull() {
givenConfigurationUnit();
DerivedAllocation.create(derivedFrom, configurationUnit);
}
- @Test(expected = IllegalArgumentException.class)
+ @Test(expected = NullPointerException.class)
public void theConfigurationUnitMustBeNotNull() {
givenDerivedFrom();
DerivedAllocation.create(derivedFrom, configurationUnit);
diff --git a/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/GenericResourceAllocationTest.java b/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/GenericResourceAllocationTest.java
index 5b45e3a9c..24ab094c8 100644
--- a/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/GenericResourceAllocationTest.java
+++ b/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/GenericResourceAllocationTest.java
@@ -47,7 +47,7 @@ import java.util.List;
import java.util.Map;
import java.util.Set;
-import org.apache.commons.lang.Validate;
+import org.apache.commons.lang3.Validate;
import org.easymock.IAnswer;
import org.easymock.EasyMock;
import org.joda.time.Interval;
diff --git a/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/ShareDivisionTest.java b/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/ShareDivisionTest.java
index 88666a069..812dcc113 100644
--- a/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/ShareDivisionTest.java
+++ b/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/ShareDivisionTest.java
@@ -61,7 +61,7 @@ public class ShareDivisionTest {
return new Share(10);
}
- @Test(expected = IllegalArgumentException.class)
+ @Test(expected = NullPointerException.class)
public void sharesCannotBeNull() {
ShareDivision.create(null);
}
diff --git a/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/StretchesFunctionTest.java b/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/StretchesFunctionTest.java
index c0846efd8..fbc174b10 100644
--- a/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/StretchesFunctionTest.java
+++ b/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/StretchesFunctionTest.java
@@ -291,7 +291,7 @@ public class StretchesFunctionTest {
assertThat(interval.getStartFor(now), equalTo(now));
}
- @Test(expected = IllegalArgumentException.class)
+ @Test(expected = NullPointerException.class)
public void endDateCannotBeNull() {
LocalDate start = new LocalDate().plusMonths(1);
new Interval(new BigDecimal(0.3), start, null);
diff --git a/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/TaskGroupTest.java b/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/TaskGroupTest.java
index 82b627c94..94ccfc3c1 100644
--- a/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/TaskGroupTest.java
+++ b/libreplan-business/src/test/java/org/libreplan/business/test/planner/entities/TaskGroupTest.java
@@ -82,7 +82,7 @@ public class TaskGroupTest {
assertThat(child.getParent(), equalTo(taskGroup));
}
- @Test(expected = IllegalArgumentException.class)
+ @Test(expected = NullPointerException.class)
public void cantAddNullTaskElement() {
taskGroup.addTaskElement(null);
}
diff --git a/libreplan-business/src/test/java/org/libreplan/business/test/qualityforms/entities/QualityFormTest.java b/libreplan-business/src/test/java/org/libreplan/business/test/qualityforms/entities/QualityFormTest.java
index 855a460f6..163592350 100644
--- a/libreplan-business/src/test/java/org/libreplan/business/test/qualityforms/entities/QualityFormTest.java
+++ b/libreplan-business/src/test/java/org/libreplan/business/test/qualityforms/entities/QualityFormTest.java
@@ -81,9 +81,7 @@ public class QualityFormTest extends AbstractQualityFormTest {
qualityForm.setQualityFormType(null);
qualityFormDAO.save(qualityForm);
fail("It should throw an exception");
- } catch (ValidationException e) {
- // It should throw an exception
- } catch (IllegalArgumentException e) {
+ } catch (ValidationException | NullPointerException e) {
// It should throw an exception
}
}
diff --git a/libreplan-business/src/test/java/org/libreplan/business/test/resources/entities/IntervalTest.java b/libreplan-business/src/test/java/org/libreplan/business/test/resources/entities/IntervalTest.java
index a06d98082..47bb6d801 100644
--- a/libreplan-business/src/test/java/org/libreplan/business/test/resources/entities/IntervalTest.java
+++ b/libreplan-business/src/test/java/org/libreplan/business/test/resources/entities/IntervalTest.java
@@ -38,7 +38,7 @@ public class IntervalTest {
CriterionSatisfactionDAOTest.year(1999));
}
- @Test(expected = IllegalArgumentException.class)
+ @Test(expected = NullPointerException.class)
public void testStartDateMustBeNotNull() {
Interval.range(null, CriterionSatisfactionDAOTest.year(1999));
}
diff --git a/libreplan-business/src/test/java/org/libreplan/business/test/resources/entities/ResourceTest.java b/libreplan-business/src/test/java/org/libreplan/business/test/resources/entities/ResourceTest.java
index 1e9d638df..698a04326 100644
--- a/libreplan-business/src/test/java/org/libreplan/business/test/resources/entities/ResourceTest.java
+++ b/libreplan-business/src/test/java/org/libreplan/business/test/resources/entities/ResourceTest.java
@@ -396,7 +396,7 @@ public class ResourceTest {
try {
worker.addSatisfaction(criterionType, wrong);
fail("must send exception");
- } catch (IllegalArgumentException e) {
+ } catch (NullPointerException | IllegalArgumentException e) {
// ok
}
}
@@ -514,7 +514,7 @@ public class ResourceTest {
private Worker worker;
private List