From ebbf074fa389731622acf00298e566f93d592677 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=93scar=20Gonz=C3=A1lez=20Fern=C3=A1ndez?= Date: Mon, 28 Dec 2009 12:34:40 +0100 Subject: [PATCH] ItEr41S11CUConfiguracionMaquinasItEr40S15: No criterions at configuration unit means no workers matched --- .../navalplanner/business/planner/entities/Task.java | 3 +++ .../planner/allocation/ResourceAllocationModel.java | 11 ++++++++--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/navalplanner-business/src/main/java/org/navalplanner/business/planner/entities/Task.java b/navalplanner-business/src/main/java/org/navalplanner/business/planner/entities/Task.java index cc4c06436..c2acb3c13 100644 --- a/navalplanner-business/src/main/java/org/navalplanner/business/planner/entities/Task.java +++ b/navalplanner-business/src/main/java/org/navalplanner/business/planner/entities/Task.java @@ -368,6 +368,9 @@ public class Task extends TaskElement { @Override public Collection findWorkersMatching( Collection requiredCriterions) { + if (requiredCriterions.isEmpty()) { + return new ArrayList(); + } Collection result = new ArrayList(); for (Worker each : allWorkers) { if (each.satisfiesCriterions(requiredCriterions)) { diff --git a/navalplanner-webapp/src/main/java/org/navalplanner/web/planner/allocation/ResourceAllocationModel.java b/navalplanner-webapp/src/main/java/org/navalplanner/web/planner/allocation/ResourceAllocationModel.java index b217d204a..e55163a12 100644 --- a/navalplanner-webapp/src/main/java/org/navalplanner/web/planner/allocation/ResourceAllocationModel.java +++ b/navalplanner-webapp/src/main/java/org/navalplanner/web/planner/allocation/ResourceAllocationModel.java @@ -234,10 +234,15 @@ public class ResourceAllocationModel implements IResourceAllocationModel { public Collection findWorkersMatching( Collection requiredCriterions) { reassociateResourcesWithSession(); - List findAllSatisfyingCriterions = resourceDAO - .findAllSatisfyingCriterions(requiredCriterions); + List allSatisfyingCriterions; + if (!requiredCriterions.isEmpty()) { + allSatisfyingCriterions = resourceDAO + .findAllSatisfyingCriterions(requiredCriterions); + } else { + allSatisfyingCriterions = new ArrayList(); + } return Resource.workers(reloadResources(Resource - .workers(findAllSatisfyingCriterions))); + .workers(allSatisfyingCriterions))); } }; }