From ef2de60f0a1f57ec73522f09ccbc8deb76b0e908 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pablo=20Fern=C3=A1ndez=20de=20la=20Cigo=C3=B1a=20N=C3=B3vo?=
 =?UTF-8?q?a?= <pcigonha@igalia.com>
Date: Tue, 9 Aug 2011 17:18:49 +0200
Subject: [PATCH] Fix some probles with the method
 BaseCRUDController:updateWindowTitle and also add new test to comprobate the
 correct working of precission and Max Value.

Added the following tests:

4 - Comprobate Max value and precission
  4.1 - Wrong values (last input precission)
  4.2 - Wrong values (last input Max Value)

FEA: ItEr75S18DataTypesTests
---
 .../data-types/progress_test.sah              | 58 +++++++++++++++----
 1 file changed, 46 insertions(+), 12 deletions(-)

diff --git a/scripts/functional-tests/data-types/progress_test.sah b/scripts/functional-tests/data-types/progress_test.sah
index 4b310e5b0..5c0c2ea45 100644
--- a/scripts/functional-tests/data-types/progress_test.sah
+++ b/scripts/functional-tests/data-types/progress_test.sah
@@ -23,15 +23,18 @@
  * 1 - Create a new process
  * 2 - Create a process with the same name (most be failure)
  * 3 - Create a new process without name (most be failure)
- * 4 - Edit a process
- * 5 - Try to delete a previously assigned progress (most be failure)
- *   5.1 - Create a Project
- *   5.2 - Assign a progress to a project
- *   5.3 - try to delete this progress
- *   5.4 - Delete the previously created project
- * 6 - Delete a process
- * 7 - Try to edit a default value
- * 8 - Try to delete a default value
+ * 4 - Check Max value and precision
+ *   4.1 - Wrong values (last input precision)
+ *   4.2 - Wrong values (last input Max Value)
+ * 5 - Edit a process
+ * 6 - Try to delete a previously assigned progress (most be failure)
+ *   6.1 - Create a Project
+ *   6.2 - Assign a progress to a project
+ *   6.3 - try to delete this progress
+ *   6.4 - Delete the previously created project
+ * 7 - Delete a process
+ * 8 - Try to edit a default value
+ * 9 - Try to delete a default value
 */
 _include("../common_functions.sah");
 
@@ -56,7 +59,8 @@ function progressCreateEmpty() {
 }
 
 function progressForm($name) {
-    _setValue(_textbox(1), $name);
+    _setValue(_textbox(0, _near(_div("Unit name"))), $name);
+    _removeFocus(_textbox(0, _near(_div("Unit name"))));
     _click(_cell("Save"));
 }
 
@@ -66,8 +70,34 @@ function progressNotValid(){
     _assert(_isVisible(_div("The name is not valid, there is another progress type with the same name.")));
 }
 
+function progressCreateWrongPrecisson($name, $maxValue, $precission){
+    progressPrecisson($name, $maxValue, $precission);
+    progressMaxValue($name, $maxValue, $precission);
+}
+
+function progressPrecisson($name, $maxValue, $precission){
+    commonCreate("Progress");
+    _setValue(_textbox(0, _near(_div("Unit name"))), $name);
+    _removeFocus(_textbox(0, _near(_div("Unit name"))));
+    _setValue(_textbox(0, _near(_div("Default max value"))), $maxValue);
+    _setValue(_textbox(0, _near(_div("Precision"))), $precission);
+    _click(_cell("Save"));
+    _assertExists(_div("Value is not valid, the Precision value must be less than the defalt max value."));
+    _assert(_isVisible(_div("Value is not valid, the Precision value must be less than the defalt max value.")));
+}
+
+function progressMaxValue($name, $maxValue, $precission){
+    commonCreate("Progress");
+    _setValue(_textbox(0, _near(_div("Unit name"))), $name);
+    _removeFocus(_textbox(0, _near(_div("Unit name"))));
+    _setValue(_textbox(0, _near(_div("Precision"))), $precission);
+    _setValue(_textbox(0, _near(_div("Default max value"))), $maxValue);
+    _click(_cell("Save"));
+    _assertExists(_div("Value is not valid, the default max value must be greater than the precision value"));
+    _assert(_isVisible(_div("Value is not valid, the default max value must be greater than the precision value")));
+}
 function progressEdit($oldName, $newName, $cell) {
-    commonEdit($oldName,3);
+    commonEdit($oldName, 3);
     progressForm($newName);
     commonSaveValidation("Progress Type", $newName);
 }
@@ -104,7 +134,7 @@ function progressAssignProject($projectName, $progressNewName){
     _click(_cell("Add new progress assignment"));
     _setValue(_textbox("z-combobox-inp", _near(_row("footer"))), $progressNewName);
     _setValue(_textbox("z-decimalbox", _near(_textbox("z-combobox-inp"))),"10.00");
-    _setValue(_textbox("z-decimalbox", _near(_textbox("z-combobox-inp"))),"10.00");
+    _removeFocus(_textbox("z-decimalbox", _near(_textbox("z-combobox-inp"))));
     _click(_cell("Add measure"));
     _click(_cell("z-button-cm[37]", _near(_row("footer"))));
     _setValue(_textbox(0, _near(_parentTable(_div("Value")))), "0.1");
@@ -117,6 +147,9 @@ var $progressName = "new";
 var $progressNewName = "newest";
 var $defaultValue = "units";
 var $projectName = "new project";
+var $progressMaxValue = "10";
+var $progressPrecission = "90";
+
 
 /* test actions */
 
@@ -124,6 +157,7 @@ commonLogin("admin", "admin");
 progressCreate($progressName);
 progressCreateDuplicate($progressName);
 progressCreateEmpty();
+progressCreateWrongPrecisson($progressNewName, $progressMaxValue, $progressPrecission);
 progressEdit($progressName, $progressNewName, 3);
 progressAssigned($projectName, $progressNewName);
 commonDelete("Progress", $progressNewName, 3);