RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Bug #1444: Save affected parent TaskElements in the end of the process.

Browse source 
We make sure that all TaskElements have been processed before saving.

FEA: ItEr76S04BugFixing
This commit is contained in:
Jacobo Aragunde Pérez 2012-05-15 09:39:45 +02:00
parent 70cecf14a7
commit f71d266f8d
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
libreplan-webapp/src/main/java/org/libreplan/web/planner/order/SaveCommandBuilder.java
View file

@ -398,6 +398,7 @@ public class SaveCommandBuilder {
private void removeTaskElementsWithTaskSourceNull() {
List<TaskElement> toRemove = taskElementDAO
.getTaskElementsNoMilestonesWithoutTaskSource();
List<TaskElement> toRemoveLater = new ArrayList<TaskElement>();
for (TaskElement taskElement : toRemove) {
try {
taskElementDAO.remove(taskElement.getId());
@ -405,7 +406,7 @@ public class SaveCommandBuilder {
TaskGroup parent = taskElement.getParent();
if (parent != null && !toRemove.contains(parent)) {
parent.remove(taskElement);
taskElementDAO.save(parent);
toRemoveLater.add(parent);
}
LOG.info("TaskElement removed because of TaskSource was null. "
@ -416,6 +417,9 @@ public class SaveCommandBuilder {
// so if it's not in the database there isn't any problem
}
}
for (TaskElement taskElement : toRemoveLater) {
taskElementDAO.save(taskElement);
}
}
private void saveOrderAuthorizations() {