RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ItEr33S08ValidacionEProbasFuncionaisItEr32S09: Fixing direct equality comparison of Longs

Browse source
This commit is contained in:
Óscar González Fernández 2009-11-03 18:25:38 +01:00
parent 4aba138ec9
commit fa0446b8ef
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
navalplanner-business/src/main/java/org/navalplanner/business/resources/entities/CriterionType.java
View file

@ -298,7 +298,7 @@ public class CriterionType extends BaseEntity implements
} else {
try {
CriterionType c = criterionTypeDAO.findUniqueByName(name);
return c.getId() == getId();
return c.getId().equals(getId());
} catch (InstanceNotFoundException e) {
return true;
}

8
navalplanner-webapp/src/main/java/org/navalplanner/web/orders/ManageOrderElementAdvancesModel.java
View file

@ -295,9 +295,9 @@ public class ManageOrderElementAdvancesModel implements
@Override
@Transactional(readOnly = true)
public void confirmSave()throws InstanceNotFoundException,
DuplicateAdvanceAssignmentForOrderElementException,
DuplicateValueTrueReportGlobalAdvanceException{
public void confirmSave() throws InstanceNotFoundException,
DuplicateAdvanceAssignmentForOrderElementException,
DuplicateValueTrueReportGlobalAdvanceException {
orderElementDAO.checkVersion(orderElement);
reattachmentOrderElement();
validateBasicData();
@ -335,7 +335,7 @@ public class ManageOrderElementAdvancesModel implements
for (AdvanceAssignment advance : this.orderElement
.getDirectAdvanceAssignments()) {
if ((advance.getVersion() != null)
&& (advance.getId() == advanceAssignment.getId()))
&& (advance.getId().equals(advanceAssignment.getId())))
return advance;
}
return null;