From ff64e01c1f574499fdb68c74ca5f67d6572bf38c Mon Sep 17 00:00:00 2001
From: Manuel Rego Casasnovas <rego@igalia.com>
Date: Tue, 5 Jul 2011 15:32:09 +0200
Subject: [PATCH] Small fixes related with some unneeded variables.

FEA: ItEr75S06LdapAuhenticationItEr74S09
---
 .../services/LDAPCustomAuthenticationProvider.java     | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/navalplanner-webapp/src/main/java/org/navalplanner/web/users/services/LDAPCustomAuthenticationProvider.java b/navalplanner-webapp/src/main/java/org/navalplanner/web/users/services/LDAPCustomAuthenticationProvider.java
index 3d5fb65fb..dbd413355 100644
--- a/navalplanner-webapp/src/main/java/org/navalplanner/web/users/services/LDAPCustomAuthenticationProvider.java
+++ b/navalplanner-webapp/src/main/java/org/navalplanner/web/users/services/LDAPCustomAuthenticationProvider.java
@@ -275,10 +275,9 @@ public class LDAPCustomAuthenticationProvider extends
     @SuppressWarnings("unchecked")
     private List<String> getRolesUsingNodeStrategy(
             List<ConfigurationRolesLDAP> rolesLdap, String queryRoles,
-            LDAPConfiguration configuration) {
+            final LDAPConfiguration configuration) {
 
-        final LDAPConfiguration ldapConfig = configuration;
-        final String roleProperty = ldapConfig.getLdapRoleProperty();
+        String roleProperty = configuration.getLdapRoleProperty();
 
         List<String> rolesReturn = new ArrayList<String>();
         for (ConfigurationRolesLDAP roleLDAP : rolesLdap) {
@@ -296,7 +295,7 @@ public class LDAPCustomAuthenticationProvider extends
                             public Object mapFromAttributes(
                                     Attributes attributes)
                                     throws NamingException {
-                                return attributes.get(ldapConfig
+                                return attributes.get(configuration
                                         .getLdapUserId());
                             }
                         }));
@@ -314,8 +313,7 @@ public class LDAPCustomAuthenticationProvider extends
             List<ConfigurationRolesLDAP> rolesLdap, String queryRoles,
             LDAPConfiguration configuration) {
 
-        final LDAPConfiguration ldapConfig = configuration;
-        final String roleProperty = ldapConfig.getLdapRoleProperty();
+        String roleProperty = configuration.getLdapRoleProperty();
         String groupsPath = configuration.getLdapGroupPath();
 
         List<String> rolesReturn = new ArrayList<String>();