Commit graph

4337 commits

Author SHA1 Message Date
Manuel Rego Casasnovas
f335c5c0d1 ConstraintChecker does not return boolean now
ConstraintChecker throws a WrongValueException that is caught by ZK and
execution is stopped.

It's not needed it returns a boolean value.

FEA: ItEr75S04BugFixing
2011-08-08 20:47:38 +02:00
Manuel Rego Casasnovas
ba64beca69 Fix highlighted days on datebox widget in limiting resources
Solution based in 935344eade commit

FEA: ItEr75S08MigrationZK5
2011-08-08 20:36:25 +02:00
Ignacio Diaz Teijido
b29a3f013f Added popup in filters to use or not labels inheritance
FEA: ItEr75S15FilteringByLabelsPlanningGantt
2011-08-08 16:42:53 +02:00
Manuel Rego Casasnovas
4222ca684b [Bug #1134] Add checks for empty username or password
FEA: ItEr75S04BugFixing
2011-08-08 16:11:38 +02:00
Manuel Rego Casasnovas
6b746221ec [Bug #1132] Remove DayType enum in BaseCalendar
* Change message to show to user about the type of day
* DayType enum is removed as it is not needed anymore

FEA: ItEr75S04BugFixing
2011-08-05 11:08:34 +02:00
Manuel Rego Casasnovas
e910538d05 [Bug #1132] Updated calendar interface to use different colors
BaseCalendarEditionController has been modified to take account
different colors defined in CalendarExceptionTypeColor enum.

FEA: ItEr75S04BugFixing
2011-08-05 11:08:34 +02:00
Manuel Rego Casasnovas
ccc30939c2 [Bug #1132] Using a renderer in CalendarExceptionType listing
In order to show information about color enum internationalized in the
list too, it is defined a rowRenderer in
CalendarExceptionTypeCRUDController.

FEA: ItEr75S04BugFixing
2011-08-05 11:08:34 +02:00
Manuel Rego Casasnovas
4403e80f6e [Bug #1132] Modify CalendarExceptionType edition form
CalendarExceptionTypeCRUDController is adapted to new enum.

FEA: ItEr75S04BugFixing
2011-08-05 11:08:34 +02:00
Manuel Rego Casasnovas
e633a179b1 [Bug #1132] Create new enum CalendarExceptionTypeColor
The enum is being used in CalendarExceptionType and all the entities
related have been updated to work with the new enum. Web service has
also been updated.

Colors defined now are: DEFAULT (red), GREEN and BLUE. Colors to show in
the interface are just examples and should be changed in a later patch.

FEA: ItEr75S04BugFixing
2011-08-05 11:08:33 +02:00
Óscar González Fernández
343330151c [Bug #1133] Fix bug
The label types must be loaded to avoid LazyInizialitationException
when executing a validator in OrderElement.

FEA: ItEr75S04BugFixing
2011-08-04 17:38:31 +02:00
Manuel Rego Casasnovas
6fb5ee6241 Fix issue in ConstraintChecker now error messages was not being shown
Use InputElement::getText() in order to force error messages to appear
when input is not valid.

FEA: ItEr75S04BugFixing
2011-08-04 13:10:23 +02:00
Manuel Rego Casasnovas
1aeacfbf63 [Bug #1132] Fix problem with CalendarExceptionType without name
Added constraint in both zul file and entity

FEA: ItEr75S04BugFixing
2011-08-04 12:59:13 +02:00
Manuel Rego Casasnovas
71fa130612 Fix problem in ConstraintChecker
* Previously ConstraintChecker was only working with Textbox and
  Datebox, now it should work for any InputElement

FEA: ItEr75S04BugFixing
2011-08-04 11:34:28 +02:00
Manuel Rego Casasnovas
935344eade Fix highlighted days on calendar widget
* CalendarHighlightedDays macro component is removed
* Solution is based on discussion at ZK forum:
  http://www.zkoss.org/forum/listComment/17068-Highlight-calendar-days-with-jQuery

FEA: ItEr75S08MigrationZK5
2011-08-04 09:58:28 +02:00
Óscar González Fernández
a4b0324139 Use ContiguousDaysLine at OrderPlanningModel
ResourceLoadChartData extractors are reused.

FEA: ItEr75S11PreventLooseChanges
2011-08-03 20:13:32 +02:00
Óscar González Fernández
9592435f8f Fix problem with chart colors
Some chart stacks were hidden by the others. Adding them in the right
order.

FEA: ItEr75S04BugFixing
2011-08-03 19:39:24 +02:00
Óscar González Fernández
fbf97300c4 Extract class for filling load charts
ResourceLoadController and CompanyPlanningModel now use this class.

FEA: ItEr75S11PreventLooseChanges
2011-08-02 19:57:46 +02:00
Manuel Rego Casasnovas
4aba29d69c Fix wrong label in "Work And Progress Per Task" report
FEA: ItEr75S04BugFixing
2011-08-02 19:49:37 +02:00
Manuel Rego Casasnovas
ed42d91f63 [Bug #1130] Fix issue changing text size and moving box
FEA: ItEr75S04BugFixing
2011-08-02 19:46:57 +02:00
Manuel Rego Casasnovas
d0ceea9276 [Bug #1107] Fix issue preventing NullPointerException
FEA: ItEr75S04BugFixing
2011-08-02 19:34:14 +02:00
Manuel Rego Casasnovas
313f66c0e0 [Bug #1113] Fix issue marking as not transient all allocations
To reproduce the issue is was needed to create a resource allocation not
satisfied and save it twice.

The problem was that only satisfied allocations were being marked as not
transient.

FEA: ItEr75S04BugFixing
2011-08-02 18:51:59 +02:00
Manuel Rego Casasnovas
5c564f2b1e [Bug #1129] Fix bug setting scale for progress value
FEA: ItEr75S04BugFixing
2011-08-02 17:52:45 +02:00
Manuel Rego Casasnovas
7bdc38eb2f [Bug #1111] Fix name and code of tasks in report
FEA: ItEr75S04BugFixing
2011-08-02 15:48:39 +02:00
Óscar González Fernández
c80d329c2a Define CompanyPlanningModel using annotations
Initially CompanyPlanningModel was defined in XML file because
method-lookups were needed. Since currently the scope of
CompanyPlanningModel is prototype, this is no longer needed.

FEA: ItEr75S04BugFixing
2011-08-02 15:16:44 +02:00
Óscar González Fernández
fb7d05ab0e Define OrderPlanningModel using annotations
Initially OrderPlanningModel was defined in XML file because
method-lookups were needed. Since currently the scope of
OrderPlanningModel is prototype, this is no longer needed.

FEA: ItEr75S04BugFixing
2011-08-02 15:12:38 +02:00
Óscar González Fernández
ccabbb6afc Remove not in effect annotations
They are potentially misleading, these beans are defined in the xml
file and their real scope is prototype.

FEA: ItEr75S04BugFixing
2011-08-02 15:12:24 +02:00
Cristina Alvarino
154626d714 [Bug # 1111] Fix several issues in report: Task Scheduling Status In Project
FEA: ItEr75S04BugFixing
2011-08-02 11:43:17 +02:00
Óscar González Fernández
9555ab4645 Show the precise efforts instead of the rounded amount in hours
FEA: ItEr75S04BugFixing
2011-08-01 19:56:56 +02:00
Óscar González Fernández
b04d6b7ba1 Use a valid url-pattern
Tomcat 6 complaints about the url pattern. Changes on it were done for
doing some workarounds in ZK5 support, but it doesn't seem necessary.

FEA: ItEr75S04BugFixing
2011-08-01 19:22:30 +02:00
Óscar González Fernández
6d44f44c1a Switch to GanttDates
Otherwise LoadPeriods of less than one day would not be shown.

FEA: ItEr75S04BugFixing
2011-08-01 19:20:49 +02:00
Óscar González Fernández
c6cbb12833 [Bug #1124] Fix problem when calculating assigned duration
When an interval of an allocation is considered and a day assignment
is within that interval, the day assignment must not be summed
completely. Only the part that is inside of the said interval.

In other words, intervals can start and end in the middle of a day,
so not all the effort of the DayAssignment must be considered.

FEA: ItEr75S04BugFixing
2011-08-01 19:20:42 +02:00
Óscar González Fernández
d75f0fee1b Unify advanced allocation state
Now it uses the current state the allocation is in.

FEA: ItEr75S11PreventLooseChanges
2011-07-28 18:05:01 +02:00
Óscar González Fernández
00db73a60f Take into account the scenario
It's extracted into a QueryPart

FEA: ItEr75S11PreventLooseChanges
2011-07-27 19:20:35 +02:00
Óscar González Fernández
a1bea29ac3 Fix the check for checking if an allocation belongs to the order
It would fail if the scenario is not the owner one.

FEA: ItEr75S11PreventLooseChanges
2011-07-27 19:11:39 +02:00
Óscar González Fernández
eb75cb1159 [Bug #1122] Fix bug
Add guard to check that the planningState is not empty.

FEA: ItEr75S04BugFixing
2011-07-27 13:56:54 +02:00
Manuel Rego Casasnovas
e8d904abbe [Bug #1117] Fix issue changing I18nHelper in business.
Current I18nHelper in business was doing real translation of strings.
Then it was passing the string translated to server language to webapp
module and this module tries to translate the string again to end-user
language.

In order to avoid this I18nHelper in business is modified and now it
just provides a marker method for translatable strings. Real translation
is going to be done in webapp module.

Several files need to be modified due to this change.

FEA: ItEr75S04BugFixing
2011-07-25 15:55:44 +02:00
Manuel Rego Casasnovas
ed79e453f6 Avoid workaround to not allow select rows in calendars tree.
Finally using nonselectableTags="*", it works properly in ZK 5.0.7.

This fix the workaround from commit:
adf65e08bf

FEA: ItEr75S05CalendarAdminInterfaceItEr74S06
2011-07-22 19:25:33 +02:00
Óscar González Fernández
3cc756bbc3 Upgrade ZK version to 5.0.7
A dependency from timelinez must be excluded, otherwise it would
include a previous version of zcommon not compatible with the new ZK
version.

FEA: ItEr75S04BugFixing
2011-07-22 18:55:12 +02:00
Óscar González Fernández
3e44be3899 Port client enhacements of BandboxMultipleSearch to ZK5
Now it closes automatically when clicking in a row as it was doing in
ZK3.

FEA: ItEr75S04BugFixing
2011-07-22 18:41:14 +02:00
Manuel Rego Casasnovas
f031dd5a7f [Bug #1115] Fix bug and add new ProgressType for spread progress
Calculation done for progress of all tasks it was really showing the
spread progress.

Then a new ProgressType is created and calculation is fixed.

FEA: ItEr75S04BugFixing
2011-07-22 13:23:23 +02:00
Manuel Rego Casasnovas
a91f9108ca Change the way to update advances in parent elements.
Before this where managed when saving the order in one case
(OrderModel) and when a progress was modified in another case
(AdvanceAssignmentPlanningModel).

Now, it's directly done in the entity OrderElement and the method is
called when a progress is modified (from AdvanceAssignmentPlanningModel,
ManageOrderElementAdvancesModel and ReportAdvancesServiceREST).

FEA: ItEr75S04BugFixing
2011-07-22 13:20:28 +02:00
Manuel Rego Casasnovas
adf65e08bf Not allow select rows in calendar tree.
Workaround to disable select rows in tree using nonselectableTags
attribute.

FEA: ItEr75S05CalendarAdminInterfaceItEr74S06
2011-07-22 07:52:15 +02:00
Óscar González Fernández
3ad1c801a6 Don't use the returned by queries allocations belonging to the order
Instead those allocations should be retrieved directly from the order
so it works well when the scenario is not the owner one and with newly
added allocations.

FEA: ItEr75S11PreventLooseChanges
2011-07-21 19:59:11 +02:00
Óscar González Fernández
1be0a2a7a5 Remove spurious annotation
It wasn't having any effect.

FEA: ItEr75S11PreventLooseChanges
2011-07-21 19:58:40 +02:00
Óscar González Fernández
9fe98c932d Reattach the order
The order and resources already present in PlanningState are reused.

FEA: ItEr75S11PreventLooseChanges
2011-07-21 19:58:39 +02:00
Óscar González Fernández
7638720136 Provide PlanningState to ResourceLoadModel
FEA: ItEr75S11PreventLooseChanges
2011-07-21 19:32:26 +02:00
Óscar González Fernández
561ad86a4a Move PlanningState to within PlanningStateCreator
This allows to use directly the Spring beans injected on
PlanningStateCreator by PlanningState. No need to provide them in the
constructors, so bloat is reduced.

FEA: ItEr75S11PreventLooseChanges
2011-07-21 19:32:26 +02:00
Óscar González Fernández
215e03174f Reuse PlanningState
Do not recreate it each time the Gantt is accessed.

FEA: ItEr75S11PreventLooseChanges
2011-07-21 19:32:26 +02:00
Manuel Rego Casasnovas
ba6b685e19 [Bug #1088] Fixed issue in earned value chart
As earned value is using
JustDaysWithInformationGraphicSpecificationCreator it's not needed to
print intervals but just one point so now it uses printLine instead of
printIntervalLine.

FEA: ItEr75S04BugFixing
2011-07-21 14:05:20 +02:00
Susana Montes Pedreira
ef9cad7e5a Revert "[Bug #1088] fix the representation of the chart of earned value month and upper zoom"
This reverts commit 867076e8fd.
2011-07-21 13:29:05 +02:00